Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
gitlab-ce
Commits
e8bab842
Commit
e8bab842
authored
Jul 20, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Cleanup that a bit
parent
782b384f
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
27 additions
and
42 deletions
+27
-42
spec/models/project_spec.rb
spec/models/project_spec.rb
+27
-42
No files found.
spec/models/project_spec.rb
View file @
e8bab842
...
...
@@ -1115,42 +1115,22 @@ describe Project, models: true do
end
describe
'#latest_successful_builds_for'
do
def
create_pipeline
def
create_pipeline
(
status
=
'success'
)
create
(
:ci_pipeline
,
project:
project
,
sha:
project
.
commit
.
sha
,
ref:
project
.
default_branch
,
status:
'success'
)
status:
status
)
end
def
create_build
(
new_pipeline
=
pipeline
,
name
=
'test'
)
create
(
:ci_build
,
:success
,
:artifacts
,
pipeline:
new_pipeline
,
status:
new_pipeline
.
status
,
name:
name
)
end
let
(
:project
)
{
create
(
:project
)
}
let
(
:pipeline
)
{
create_pipeline
}
let
(
:build
)
{
create_build
}
context
'with succeeded pipeline'
do
context
'standalone pipeline'
do
before
do
build
end
it
'returns builds for ref for default_branch'
do
builds
=
project
.
latest_successful_builds_for
expect
(
builds
).
to
contain_exactly
(
build
)
end
it
'returns empty relation if the build cannot be found'
do
builds
=
project
.
latest_successful_builds_for
(
'TAIL'
)
expect
(
builds
).
to
be_kind_of
(
ActiveRecord
::
Relation
)
expect
(
builds
).
to
be_empty
end
end
context
'with many builds'
do
before
do
...
...
@@ -1169,28 +1149,33 @@ describe Project, models: true do
end
end
context
'with multiple pipelines and builds'
do
shared_examples
'latest successful one'
do
it
'gives the latest build from latest pipeline'
do
latest_build
=
project
.
latest_successful_builds_for
.
first
context
'with succeeded pipeline'
do
let!
(
:build
)
{
create_build
}
context
'standalone pipeline'
do
it
'returns builds for ref for default_branch'
do
builds
=
project
.
latest_successful_builds_for
expect
(
latest_build
).
to
eq
(
build
)
expect
(
builds
).
to
contain_exactly
(
build
)
end
it
'returns empty relation if the build cannot be found'
do
builds
=
project
.
latest_successful_builds_for
(
'TAIL'
)
expect
(
builds
).
to
be_kind_of
(
ActiveRecord
::
Relation
)
expect
(
builds
).
to
be_empty
end
end
context
'with some pending pipeline'
do
before
do
# make sure pipeline was old, but still the latest success one
build
new_pipeline
=
create
(
:ci_pipeline
,
project:
project
,
sha:
project
.
commit
.
sha
,
ref:
project
.
default_branch
,
status:
'pending'
)
create
(
:ci_build
,
:pending
,
:artifacts
,
pipeline:
new_pipeline
)
create_build
(
create_pipeline
(
'pending'
))
end
it_behaves_like
'latest successful one'
it
'gives the latest build from latest pipeline'
do
latest_build
=
project
.
latest_successful_builds_for
expect
(
latest_build
).
to
contain_exactly
(
build
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment