Commit 856fd8f5 authored by Mark Ryan's avatar Mark Ryan Committed by Brad Fitzpatrick

encoding/ascii85: make bigtest big again

ascii85_test.go contains a variable called bigtest that is used as
test data for TestDecoderBuffering and TestEncoderBuffering.  The
variable is initialised to a copy of the last element of the pairs
slice.  When the variable was first added the last element of this
slice contained a sizable test case, 342 encoded characters.  However,
https://golang.org/cl/5970078 added a new element to the end of the pairs
slice without updating bigtest.  As the new element contained only 1 byte
of encoded data bigtest became very small test.  This commit fixes the
problem by resetting bigtest to its original value and making its
initialisation independent of the layout of pairs.  All the unit tests
still pass.

Change-Id: If7fb609ced9da93a2321dfd8372986b2fa772fd5
Reviewed-on: https://go-review.googlesource.com/46475Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 43ae54ba
...@@ -16,14 +16,7 @@ type testpair struct { ...@@ -16,14 +16,7 @@ type testpair struct {
decoded, encoded string decoded, encoded string
} }
var pairs = []testpair{ var bigtest = testpair{
// Encode returns 0 when len(src) is 0
{
"",
"",
},
// Wikipedia example
{
"Man is distinguished, not only by his reason, but by this singular passion from " + "Man is distinguished, not only by his reason, but by this singular passion from " +
"other animals, which is a lust of the mind, that by a perseverance of delight in " + "other animals, which is a lust of the mind, that by a perseverance of delight in " +
"the continued and indefatigable generation of knowledge, exceeds the short " + "the continued and indefatigable generation of knowledge, exceeds the short " +
...@@ -33,7 +26,16 @@ var pairs = []testpair{ ...@@ -33,7 +26,16 @@ var pairs = []testpair{
"i(DIb:@FD,*)+C]U=@3BN#EcYf8ATD3s@q?d$AftVqCh[NqF<G:8+EV:.+Cf>-FD5W8ARlolDIa\n" + "i(DIb:@FD,*)+C]U=@3BN#EcYf8ATD3s@q?d$AftVqCh[NqF<G:8+EV:.+Cf>-FD5W8ARlolDIa\n" +
"l(DId<j@<?3r@:F%a+D58'ATD4$Bl@l3De:,-DJs`8ARoFb/0JMK@qB4^F!,R<AKZ&-DfTqBG%G\n" + "l(DId<j@<?3r@:F%a+D58'ATD4$Bl@l3De:,-DJs`8ARoFb/0JMK@qB4^F!,R<AKZ&-DfTqBG%G\n" +
">uD.RTpAKYo'+CT/5+Cei#DII?(E,9)oF*2M7/c\n", ">uD.RTpAKYo'+CT/5+Cei#DII?(E,9)oF*2M7/c\n",
}
var pairs = []testpair{
// Encode returns 0 when len(src) is 0
{
"",
"",
}, },
// Wikipedia example
bigtest,
// Special case when shortening !!!!! to z. // Special case when shortening !!!!! to z.
{ {
"\000\000\000\000", "\000\000\000\000",
...@@ -41,8 +43,6 @@ var pairs = []testpair{ ...@@ -41,8 +43,6 @@ var pairs = []testpair{
}, },
} }
var bigtest = pairs[len(pairs)-1]
func testEqual(t *testing.T, msg string, args ...interface{}) bool { func testEqual(t *testing.T, msg string, args ...interface{}) bool {
t.Helper() t.Helper()
if args[len(args)-2] != args[len(args)-1] { if args[len(args)-2] != args[len(args)-1] {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment