Commit fbd48a37 authored by Michael Stapelberg's avatar Michael Stapelberg

fix/skip tests for Go 1.13

See https://golang.org/doc/go1.13#os for the corresponding change.
parent 90d93355
...@@ -775,7 +775,7 @@ func (t *MemFSTest) WriteAtDoesntChangeOffset_AppendMode() { ...@@ -775,7 +775,7 @@ func (t *MemFSTest) WriteAtDoesntChangeOffset_AppendMode() {
// Create a file in append mode. // Create a file in append mode.
f, err := os.OpenFile( f, err := os.OpenFile(
path.Join(t.Dir, "foo"), path.Join(t.Dir, "foo"),
os.O_RDWR|os.O_APPEND|os.O_CREATE, os.O_RDWR|os.O_CREATE,
0600) 0600)
t.ToClose = append(t.ToClose, f) t.ToClose = append(t.ToClose, f)
...@@ -851,11 +851,6 @@ func (t *MemFSTest) AppendMode() { ...@@ -851,11 +851,6 @@ func (t *MemFSTest) AppendMode() {
AssertEq(nil, err) AssertEq(nil, err)
ExpectEq(13, off) ExpectEq(13, off)
// A random write should still work, without updating the offset.
n, err = f.WriteAt([]byte("H"), 0)
AssertEq(nil, err)
AssertEq(1, n)
off, err = getFileOffset(f) off, err = getFileOffset(f)
AssertEq(nil, err) AssertEq(nil, err)
ExpectEq(13, off) ExpectEq(13, off)
...@@ -873,7 +868,7 @@ func (t *MemFSTest) AppendMode() { ...@@ -873,7 +868,7 @@ func (t *MemFSTest) AppendMode() {
// So we allow either the POSIX result or the Linux result. // So we allow either the POSIX result or the Linux result.
n, err = f.ReadAt(buf, 0) n, err = f.ReadAt(buf, 0)
AssertEq(io.EOF, err) AssertEq(io.EOF, err)
ExpectThat(string(buf[:n]), AnyOf("Hello, world!", "Jello, world!H")) ExpectThat(string(buf[:n]), AnyOf("Jello, world!", "Jello, world!H"))
} }
func (t *MemFSTest) ReadsPastEndOfFile() { func (t *MemFSTest) ReadsPastEndOfFile() {
......
...@@ -167,6 +167,7 @@ func (t *PosixTest) WriteStartsPastEndOfFile() { ...@@ -167,6 +167,7 @@ func (t *PosixTest) WriteStartsPastEndOfFile() {
} }
func (t *PosixTest) WriteStartsPastEndOfFile_AppendMode() { func (t *PosixTest) WriteStartsPastEndOfFile_AppendMode() {
return // WriteAt on O_APPEND files returns an error starting with Go 1.13
var err error var err error
var n int var n int
...@@ -237,6 +238,7 @@ func (t *PosixTest) WriteAtDoesntChangeOffset_NotAppendMode() { ...@@ -237,6 +238,7 @@ func (t *PosixTest) WriteAtDoesntChangeOffset_NotAppendMode() {
} }
func (t *PosixTest) WriteAtDoesntChangeOffset_AppendMode() { func (t *PosixTest) WriteAtDoesntChangeOffset_AppendMode() {
return // WriteAt on O_APPEND files returns an error starting with Go 1.13
var err error var err error
var n int var n int
...@@ -269,6 +271,7 @@ func (t *PosixTest) WriteAtDoesntChangeOffset_AppendMode() { ...@@ -269,6 +271,7 @@ func (t *PosixTest) WriteAtDoesntChangeOffset_AppendMode() {
} }
func (t *PosixTest) AppendMode() { func (t *PosixTest) AppendMode() {
return // WriteAt on O_APPEND files returns an error starting with Go 1.13
var err error var err error
var n int var n int
var off int64 var off int64
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment