Commit 04c3040f authored by Stefan Wahren's avatar Stefan Wahren Committed by Kleber Sacilotto de Souza

net: qca_spi: Fix log level if probe fails

BugLink: https://bugs.launchpad.net/bugs/1792377

[ Upstream commit 50973993 ]

In cases the probing fails the log level of the messages should
be an error.
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent b40e80eb
...@@ -868,21 +868,21 @@ qca_spi_probe(struct spi_device *spi) ...@@ -868,21 +868,21 @@ qca_spi_probe(struct spi_device *spi)
if ((qcaspi_clkspeed < QCASPI_CLK_SPEED_MIN) || if ((qcaspi_clkspeed < QCASPI_CLK_SPEED_MIN) ||
(qcaspi_clkspeed > QCASPI_CLK_SPEED_MAX)) { (qcaspi_clkspeed > QCASPI_CLK_SPEED_MAX)) {
dev_info(&spi->dev, "Invalid clkspeed: %d\n", dev_err(&spi->dev, "Invalid clkspeed: %d\n",
qcaspi_clkspeed); qcaspi_clkspeed);
return -EINVAL; return -EINVAL;
} }
if ((qcaspi_burst_len < QCASPI_BURST_LEN_MIN) || if ((qcaspi_burst_len < QCASPI_BURST_LEN_MIN) ||
(qcaspi_burst_len > QCASPI_BURST_LEN_MAX)) { (qcaspi_burst_len > QCASPI_BURST_LEN_MAX)) {
dev_info(&spi->dev, "Invalid burst len: %d\n", dev_err(&spi->dev, "Invalid burst len: %d\n",
qcaspi_burst_len); qcaspi_burst_len);
return -EINVAL; return -EINVAL;
} }
if ((qcaspi_pluggable < QCASPI_PLUGGABLE_MIN) || if ((qcaspi_pluggable < QCASPI_PLUGGABLE_MIN) ||
(qcaspi_pluggable > QCASPI_PLUGGABLE_MAX)) { (qcaspi_pluggable > QCASPI_PLUGGABLE_MAX)) {
dev_info(&spi->dev, "Invalid pluggable: %d\n", dev_err(&spi->dev, "Invalid pluggable: %d\n",
qcaspi_pluggable); qcaspi_pluggable);
return -EINVAL; return -EINVAL;
} }
...@@ -944,7 +944,7 @@ qca_spi_probe(struct spi_device *spi) ...@@ -944,7 +944,7 @@ qca_spi_probe(struct spi_device *spi)
} }
if (register_netdev(qcaspi_devs)) { if (register_netdev(qcaspi_devs)) {
dev_info(&spi->dev, "Unable to register net device %s\n", dev_err(&spi->dev, "Unable to register net device %s\n",
qcaspi_devs->name); qcaspi_devs->name);
free_netdev(qcaspi_devs); free_netdev(qcaspi_devs);
return -EFAULT; return -EFAULT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment