Commit 0544c4cf authored by Eric Dumazet's avatar Eric Dumazet Committed by Kleber Sacilotto de Souza

smsc75xx: use skb_cow_head() to deal with cloned skbs

BugLink: http://bugs.launchpad.net/bugs/1745266

commit b7c6d267 upstream.

We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.

skb_cow_head() is the proper helper to deal with this.

Fixes: d0cad871 ("smsc75xx: SMSC LAN75xx USB gigabit ethernet adapter driver")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
parent 53c36634
...@@ -2193,12 +2193,8 @@ static struct sk_buff *smsc75xx_tx_fixup(struct usbnet *dev, ...@@ -2193,12 +2193,8 @@ static struct sk_buff *smsc75xx_tx_fixup(struct usbnet *dev,
{ {
u32 tx_cmd_a, tx_cmd_b; u32 tx_cmd_a, tx_cmd_b;
if (skb_headroom(skb) < SMSC75XX_TX_OVERHEAD) { if (skb_cow_head(skb, SMSC75XX_TX_OVERHEAD)) {
struct sk_buff *skb2 =
skb_copy_expand(skb, SMSC75XX_TX_OVERHEAD, 0, flags);
dev_kfree_skb_any(skb); dev_kfree_skb_any(skb);
skb = skb2;
if (!skb)
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment