Commit 05804225 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Ilpo Järvinen

platform/x86/siemens: simatic-ipc-batt: Simplify simatic_ipc_batt_remove()

Instead of unconditionally returning zero, let simatic_ipc_batt_remove()
return no value. This is a preparation to convert the drivers using this
function to struct platform_driver::remove_new().
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230927081040.2198742-24-u.kleine-koenig@pengutronix.deReviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 9e6b44d4
...@@ -27,7 +27,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_127e = { ...@@ -27,7 +27,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_127e = {
static int simatic_ipc_batt_apollolake_remove(struct platform_device *pdev) static int simatic_ipc_batt_apollolake_remove(struct platform_device *pdev)
{ {
return simatic_ipc_batt_remove(pdev, &simatic_ipc_batt_gpio_table_127e); simatic_ipc_batt_remove(pdev, &simatic_ipc_batt_gpio_table_127e);
return 0;
} }
static int simatic_ipc_batt_apollolake_probe(struct platform_device *pdev) static int simatic_ipc_batt_apollolake_probe(struct platform_device *pdev)
......
...@@ -27,7 +27,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_21a = { ...@@ -27,7 +27,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_21a = {
static int simatic_ipc_batt_elkhartlake_remove(struct platform_device *pdev) static int simatic_ipc_batt_elkhartlake_remove(struct platform_device *pdev)
{ {
return simatic_ipc_batt_remove(pdev, &simatic_ipc_batt_gpio_table_bx_21a); simatic_ipc_batt_remove(pdev, &simatic_ipc_batt_gpio_table_bx_21a);
return 0;
} }
static int simatic_ipc_batt_elkhartlake_probe(struct platform_device *pdev) static int simatic_ipc_batt_elkhartlake_probe(struct platform_device *pdev)
......
...@@ -47,7 +47,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_59a = { ...@@ -47,7 +47,9 @@ static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_59a = {
static int simatic_ipc_batt_f7188x_remove(struct platform_device *pdev) static int simatic_ipc_batt_f7188x_remove(struct platform_device *pdev)
{ {
return simatic_ipc_batt_remove(pdev, batt_lookup_table); simatic_ipc_batt_remove(pdev, batt_lookup_table);
return 0;
} }
static int simatic_ipc_batt_f7188x_probe(struct platform_device *pdev) static int simatic_ipc_batt_f7188x_probe(struct platform_device *pdev)
......
...@@ -146,10 +146,9 @@ static const struct hwmon_chip_info simatic_ipc_batt_chip_info = { ...@@ -146,10 +146,9 @@ static const struct hwmon_chip_info simatic_ipc_batt_chip_info = {
.info = simatic_ipc_batt_info, .info = simatic_ipc_batt_info,
}; };
int simatic_ipc_batt_remove(struct platform_device *pdev, struct gpiod_lookup_table *table) void simatic_ipc_batt_remove(struct platform_device *pdev, struct gpiod_lookup_table *table)
{ {
gpiod_remove_lookup_table(table); gpiod_remove_lookup_table(table);
return 0;
} }
EXPORT_SYMBOL_GPL(simatic_ipc_batt_remove); EXPORT_SYMBOL_GPL(simatic_ipc_batt_remove);
...@@ -230,7 +229,9 @@ EXPORT_SYMBOL_GPL(simatic_ipc_batt_probe); ...@@ -230,7 +229,9 @@ EXPORT_SYMBOL_GPL(simatic_ipc_batt_probe);
static int simatic_ipc_batt_io_remove(struct platform_device *pdev) static int simatic_ipc_batt_io_remove(struct platform_device *pdev)
{ {
return simatic_ipc_batt_remove(pdev, NULL); simatic_ipc_batt_remove(pdev, NULL);
return 0;
} }
static int simatic_ipc_batt_io_probe(struct platform_device *pdev) static int simatic_ipc_batt_io_probe(struct platform_device *pdev)
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
int simatic_ipc_batt_probe(struct platform_device *pdev, int simatic_ipc_batt_probe(struct platform_device *pdev,
struct gpiod_lookup_table *table); struct gpiod_lookup_table *table);
int simatic_ipc_batt_remove(struct platform_device *pdev, void simatic_ipc_batt_remove(struct platform_device *pdev,
struct gpiod_lookup_table *table); struct gpiod_lookup_table *table);
#endif /* _SIMATIC_IPC_BATT_H */ #endif /* _SIMATIC_IPC_BATT_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment