Commit 07701436 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

fbdev: auo_k190x: avoid unused function warnings

commit a8a31afa upstream.

The auo_k190x framebuffer driver encloses the power-management
functions in #ifdef CONFIG_PM, but the auok190x_suspend/resume
functions are only really used when CONFIG_PM_SLEEP is also
set, as a frequent gcc warning shows:

drivers/video/fbdev/auo_k190x.c:859:12: warning: 'auok190x_suspend' defined but not used
drivers/video/fbdev/auo_k190x.c:899:12: warning: 'auok190x_resume' defined but not used

This changes the driver to remove the #ifdef and instead mark
the functions as __maybe_unused, which is a nicer anyway, as it
provides build testing for all the code in all configurations
and is harder to get wrong.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 716fae62
...@@ -773,9 +773,7 @@ static void auok190x_recover(struct auok190xfb_par *par) ...@@ -773,9 +773,7 @@ static void auok190x_recover(struct auok190xfb_par *par)
/* /*
* Power-management * Power-management
*/ */
static int __maybe_unused auok190x_runtime_suspend(struct device *dev)
#ifdef CONFIG_PM
static int auok190x_runtime_suspend(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct fb_info *info = platform_get_drvdata(pdev); struct fb_info *info = platform_get_drvdata(pdev);
...@@ -822,7 +820,7 @@ static int auok190x_runtime_suspend(struct device *dev) ...@@ -822,7 +820,7 @@ static int auok190x_runtime_suspend(struct device *dev)
return 0; return 0;
} }
static int auok190x_runtime_resume(struct device *dev) static int __maybe_unused auok190x_runtime_resume(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct fb_info *info = platform_get_drvdata(pdev); struct fb_info *info = platform_get_drvdata(pdev);
...@@ -856,7 +854,7 @@ static int auok190x_runtime_resume(struct device *dev) ...@@ -856,7 +854,7 @@ static int auok190x_runtime_resume(struct device *dev)
return 0; return 0;
} }
static int auok190x_suspend(struct device *dev) static int __maybe_unused auok190x_suspend(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct fb_info *info = platform_get_drvdata(pdev); struct fb_info *info = platform_get_drvdata(pdev);
...@@ -896,7 +894,7 @@ static int auok190x_suspend(struct device *dev) ...@@ -896,7 +894,7 @@ static int auok190x_suspend(struct device *dev)
return 0; return 0;
} }
static int auok190x_resume(struct device *dev) static int __maybe_unused auok190x_resume(struct device *dev)
{ {
struct platform_device *pdev = to_platform_device(dev); struct platform_device *pdev = to_platform_device(dev);
struct fb_info *info = platform_get_drvdata(pdev); struct fb_info *info = platform_get_drvdata(pdev);
...@@ -933,7 +931,6 @@ static int auok190x_resume(struct device *dev) ...@@ -933,7 +931,6 @@ static int auok190x_resume(struct device *dev)
return 0; return 0;
} }
#endif
const struct dev_pm_ops auok190x_pm = { const struct dev_pm_ops auok190x_pm = {
SET_RUNTIME_PM_OPS(auok190x_runtime_suspend, auok190x_runtime_resume, SET_RUNTIME_PM_OPS(auok190x_runtime_suspend, auok190x_runtime_resume,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment