Commit 0b4f688d authored by Jakub Kicinski's avatar Jakub Kicinski

Revert "sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb"

This reverts commit 90fabae8.

Patch was applied hastily, revert and let the v2 be reviewed.

Fixes: 90fabae8 ("sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb")
Link: https://lore.kernel.org/all/87wnao2ha3.fsf@toke.dk/Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a3daac63
...@@ -1713,7 +1713,6 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ...@@ -1713,7 +1713,6 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
} }
idx--; idx--;
flow = &b->flows[idx]; flow = &b->flows[idx];
ret = NET_XMIT_SUCCESS;
/* ensure shaper state isn't stale */ /* ensure shaper state isn't stale */
if (!b->tin_backlog) { if (!b->tin_backlog) {
...@@ -1772,7 +1771,6 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ...@@ -1772,7 +1771,6 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
qdisc_tree_reduce_backlog(sch, 1-numsegs, len-slen); qdisc_tree_reduce_backlog(sch, 1-numsegs, len-slen);
consume_skb(skb); consume_skb(skb);
ret |= __NET_XMIT_STOLEN;
} else { } else {
/* not splitting */ /* not splitting */
cobalt_set_enqueue_time(skb, now); cobalt_set_enqueue_time(skb, now);
...@@ -1906,7 +1904,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ...@@ -1906,7 +1904,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
} }
b->drop_overlimit += dropped; b->drop_overlimit += dropped;
} }
return ret; return NET_XMIT_SUCCESS;
} }
static struct sk_buff *cake_dequeue_one(struct Qdisc *sch) static struct sk_buff *cake_dequeue_one(struct Qdisc *sch)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment