Commit 0bc8e009 authored by Randy Dunlap's avatar Randy Dunlap Committed by Greg Kroah-Hartman

[PATCH] USB usblp: rate-limit printer status error messages

Rate-limit usblp printer error status messages.

I unplugged my USB printer and almost instantly got several hundred
of these in my kernel message log:
drivers/usb/class/usblp.c: usblp0: error -19 reading printer status
Signed-off-by: default avatarRandy Dunlap <rdunlap@xenotime.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a1cf96ef
...@@ -310,6 +310,7 @@ static int usblp_check_status(struct usblp *usblp, int err) ...@@ -310,6 +310,7 @@ static int usblp_check_status(struct usblp *usblp, int err)
error = usblp_read_status (usblp, usblp->statusbuf); error = usblp_read_status (usblp, usblp->statusbuf);
if (error < 0) { if (error < 0) {
if (printk_ratelimit())
err("usblp%d: error %d reading printer status", err("usblp%d: error %d reading printer status",
usblp->minor, error); usblp->minor, error);
return 0; return 0;
...@@ -604,7 +605,9 @@ static int usblp_ioctl(struct inode *inode, struct file *file, unsigned int cmd, ...@@ -604,7 +605,9 @@ static int usblp_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
case LPGETSTATUS: case LPGETSTATUS:
if (usblp_read_status(usblp, usblp->statusbuf)) { if (usblp_read_status(usblp, usblp->statusbuf)) {
err("usblp%d: failed reading printer status", usblp->minor); if (printk_ratelimit())
err("usblp%d: failed reading printer status",
usblp->minor);
retval = -EIO; retval = -EIO;
goto done; goto done;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment