Commit 0cef30b8 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Bartosz Golaszewski

gpio: tps65218: remove platform_set_drvdata() + cleanup probe

The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.
Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 3660660a
...@@ -187,7 +187,6 @@ static int tps65218_gpio_probe(struct platform_device *pdev) ...@@ -187,7 +187,6 @@ static int tps65218_gpio_probe(struct platform_device *pdev)
{ {
struct tps65218 *tps65218 = dev_get_drvdata(pdev->dev.parent); struct tps65218 *tps65218 = dev_get_drvdata(pdev->dev.parent);
struct tps65218_gpio *tps65218_gpio; struct tps65218_gpio *tps65218_gpio;
int ret;
tps65218_gpio = devm_kzalloc(&pdev->dev, sizeof(*tps65218_gpio), tps65218_gpio = devm_kzalloc(&pdev->dev, sizeof(*tps65218_gpio),
GFP_KERNEL); GFP_KERNEL);
...@@ -201,16 +200,8 @@ static int tps65218_gpio_probe(struct platform_device *pdev) ...@@ -201,16 +200,8 @@ static int tps65218_gpio_probe(struct platform_device *pdev)
tps65218_gpio->gpio_chip.of_node = pdev->dev.of_node; tps65218_gpio->gpio_chip.of_node = pdev->dev.of_node;
#endif #endif
ret = devm_gpiochip_add_data(&pdev->dev, &tps65218_gpio->gpio_chip, return devm_gpiochip_add_data(&pdev->dev, &tps65218_gpio->gpio_chip,
tps65218_gpio); tps65218_gpio);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to register gpiochip, %d\n", ret);
return ret;
}
platform_set_drvdata(pdev, tps65218_gpio);
return ret;
} }
static const struct of_device_id tps65218_dt_match[] = { static const struct of_device_id tps65218_dt_match[] = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment