Commit 1116575d authored by Jean-Francois Dagenais's avatar Jean-Francois Dagenais Committed by Greg Kroah-Hartman

w1: ds2408: use ARRAY_SIZE instead of hard-coded number

Acked-by: default avatarEvgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: default avatarJean-Francois Dagenais <jeff.dagenais@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aceca285
...@@ -303,8 +303,7 @@ static ssize_t w1_f29_write_status_control( ...@@ -303,8 +303,7 @@ static ssize_t w1_f29_write_status_control(
#define NB_SYSFS_BIN_FILES 6 static struct bin_attribute w1_f29_sysfs_bin_files[] = {
static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
{ {
.attr = { .attr = {
.name = "state", .name = "state",
...@@ -363,7 +362,7 @@ static int w1_f29_add_slave(struct w1_slave *sl) ...@@ -363,7 +362,7 @@ static int w1_f29_add_slave(struct w1_slave *sl)
int err = 0; int err = 0;
int i; int i;
for (i = 0; i < NB_SYSFS_BIN_FILES && !err; ++i) for (i = 0; i < ARRAY_SIZE(w1_f29_sysfs_bin_files) && !err; ++i)
err = sysfs_create_bin_file( err = sysfs_create_bin_file(
&sl->dev.kobj, &sl->dev.kobj,
&(w1_f29_sysfs_bin_files[i])); &(w1_f29_sysfs_bin_files[i]));
...@@ -377,7 +376,7 @@ static int w1_f29_add_slave(struct w1_slave *sl) ...@@ -377,7 +376,7 @@ static int w1_f29_add_slave(struct w1_slave *sl)
static void w1_f29_remove_slave(struct w1_slave *sl) static void w1_f29_remove_slave(struct w1_slave *sl)
{ {
int i; int i;
for (i = NB_SYSFS_BIN_FILES - 1; i >= 0; --i) for (i = ARRAY_SIZE(w1_f29_sysfs_bin_files) - 1; i >= 0; --i)
sysfs_remove_bin_file(&sl->dev.kobj, sysfs_remove_bin_file(&sl->dev.kobj,
&(w1_f29_sysfs_bin_files[i])); &(w1_f29_sysfs_bin_files[i]));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment