Commit 12e0f438 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai

ALSA: firewire-lib: use dev_err() when detecting incoming streaming error

When detecting invalid value in 'dbs' field of CIP header or packet
discontinuity, current implementation reports the status by err_info().
In most cases this state is caused by model-specific issue due to
vendor's customization and should be reported to developers.

This commit use dev_err() instead of dev_info() for this purpose.
In the cases, packet streaming is aborted, thus no message floading
occurs.
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9a2820c1
...@@ -723,7 +723,7 @@ static int handle_in_packet(struct amdtp_stream *s, ...@@ -723,7 +723,7 @@ static int handle_in_packet(struct amdtp_stream *s,
(cip_header[0] & CIP_DBS_MASK) >> CIP_DBS_SHIFT; (cip_header[0] & CIP_DBS_MASK) >> CIP_DBS_SHIFT;
/* avoid division by zero */ /* avoid division by zero */
if (data_block_quadlets == 0) { if (data_block_quadlets == 0) {
dev_info_ratelimited(&s->unit->device, dev_err(&s->unit->device,
"Detect invalid value in dbs field: %08X\n", "Detect invalid value in dbs field: %08X\n",
cip_header[0]); cip_header[0]);
return -EIO; return -EIO;
...@@ -756,7 +756,7 @@ static int handle_in_packet(struct amdtp_stream *s, ...@@ -756,7 +756,7 @@ static int handle_in_packet(struct amdtp_stream *s,
} }
if (lost) { if (lost) {
dev_info(&s->unit->device, dev_err(&s->unit->device,
"Detect discontinuity of CIP: %02X %02X\n", "Detect discontinuity of CIP: %02X %02X\n",
s->data_block_counter, data_block_counter); s->data_block_counter, data_block_counter);
return -EIO; return -EIO;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment