Commit 13e1df09 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Masahiro Yamada

kheaders: explicitly validate existence of cpio command

If the cpio command is not available the error emitted by
gen_kheaders.so is not clear as all output of the call to cpio is
discarded:

GNU make 4.4:

  GEN     kernel/kheaders_data.tar.xz
find: 'standard output': Broken pipe
find: write error
make[2]: *** [kernel/Makefile:157: kernel/kheaders_data.tar.xz] Error 127
make[1]: *** [scripts/Makefile.build:504: kernel] Error 2

GNU make < 4.4:

  GEN     kernel/kheaders_data.tar.xz
make[2]: *** [kernel/Makefile:157: kernel/kheaders_data.tar.xz] Error 127
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:504: kernel] Error 2

Add an explicit check that will trigger a clear message about the issue:

  CHK     kernel/kheaders_data.tar.xz
./kernel/gen_kheaders.sh: line 17: type: cpio: not found

The other commands executed by gen_kheaders.sh are part of a standard
installation, so they are not checked.
Reported-by: default avatarAmy Parker <apark0006@student.cerritos.edu>
Link: https://lore.kernel.org/lkml/CAPOgqxFva=tOuh1UitCSN38+28q3BNXKq19rEsVNPRzRqKqZ+g@mail.gmail.com/Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Reviewed-by: default avatarNicolas Schier <n.schier@avm.de>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 8c008988
...@@ -14,6 +14,8 @@ include/ ...@@ -14,6 +14,8 @@ include/
arch/$SRCARCH/include/ arch/$SRCARCH/include/
" "
type cpio > /dev/null
# Support incremental builds by skipping archive generation # Support incremental builds by skipping archive generation
# if timestamps of files being archived are not changed. # if timestamps of files being archived are not changed.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment