Commit 13eec7ea authored by Thomas Hellstrom's avatar Thomas Hellstrom

drm/vmwgfx: Fix OTABLE takedown

Don't fence and free the BO if command submission fails.
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
parent 153b3d5b
......@@ -191,7 +191,9 @@ static void vmw_takedown_otable_base(struct vmw_private *dev_priv,
if (unlikely(cmd == NULL)) {
DRM_ERROR("Failed reserving FIFO space for OTable "
"takedown.\n");
} else {
return;
}
memset(cmd, 0, sizeof(*cmd));
cmd->header.id = SVGA_3D_CMD_SET_OTABLE_BASE;
cmd->header.size = sizeof(cmd->body);
......@@ -201,7 +203,6 @@ static void vmw_takedown_otable_base(struct vmw_private *dev_priv,
cmd->body.validSizeInBytes = 0;
cmd->body.ptDepth = SVGA3D_MOBFMT_INVALID;
vmw_fifo_commit(dev_priv, sizeof(*cmd));
}
if (bo) {
int ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment