Commit 14f6d317 authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul

dmaengine: ti: edma: handle irq_of_parse_and_map() errors

Zero is not a valid IRQ for in-kernel code and the irq_of_parse_and_map()
function returns zero on error.  So this check for valid IRQs should only
accept values > 0.

Fixes: 2b6b3b74 ("ARM/dmaengine: edma: Merge the two drivers under drivers/dma/")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/f15cb6a7-8449-4f79-98b6-34072f04edbc@moroto.mountainSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 9c6e02ea
...@@ -2401,7 +2401,7 @@ static int edma_probe(struct platform_device *pdev) ...@@ -2401,7 +2401,7 @@ static int edma_probe(struct platform_device *pdev)
if (irq < 0 && node) if (irq < 0 && node)
irq = irq_of_parse_and_map(node, 0); irq = irq_of_parse_and_map(node, 0);
if (irq >= 0) { if (irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint", irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint",
dev_name(dev)); dev_name(dev));
ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name, ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
...@@ -2417,7 +2417,7 @@ static int edma_probe(struct platform_device *pdev) ...@@ -2417,7 +2417,7 @@ static int edma_probe(struct platform_device *pdev)
if (irq < 0 && node) if (irq < 0 && node)
irq = irq_of_parse_and_map(node, 2); irq = irq_of_parse_and_map(node, 2);
if (irq >= 0) { if (irq > 0) {
irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint", irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint",
dev_name(dev)); dev_name(dev));
ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name, ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment