Commit 1677293e authored by Robert Marko's avatar Robert Marko Committed by Jakub Kicinski

net: phy: qca807x: fix compilation when CONFIG_GPIOLIB is not set

Kernel bot has discovered that if CONFIG_GPIOLIB is not set compilation
will fail.

Upon investigation the issue is that qca807x_gpio() is guarded by a
preprocessor check but then it is called under
if (IS_ENABLED(CONFIG_GPIOLIB)) in the probe call so the compiler will
error out since qca807x_gpio() has not been declared if CONFIG_GPIOLIB has
not been set.

Fixes: d1cb613e ("net: phy: qcom: add support for QCA807x PHY Family")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403031332.IGAbZzwq-lkp@intel.com/Signed-off-by: default avatarRobert Marko <robimarko@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
Link: https://lore.kernel.org/r/20240305142113.795005-1-robimarko@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 771d791d
...@@ -732,7 +732,7 @@ static int qca807x_probe(struct phy_device *phydev) ...@@ -732,7 +732,7 @@ static int qca807x_probe(struct phy_device *phydev)
priv->dac_disable_bias_current_tweak = of_property_read_bool(node, priv->dac_disable_bias_current_tweak = of_property_read_bool(node,
"qcom,dac-disable-bias-current-tweak"); "qcom,dac-disable-bias-current-tweak");
if (IS_ENABLED(CONFIG_GPIOLIB)) { #if IS_ENABLED(CONFIG_GPIOLIB)
/* Make sure we don't have mixed leds node and gpio-controller /* Make sure we don't have mixed leds node and gpio-controller
* to prevent registering leds and having gpio-controller usage * to prevent registering leds and having gpio-controller usage
* conflicting with them. * conflicting with them.
...@@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev) ...@@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev)
if (ret) if (ret)
return ret; return ret;
} }
} #endif
/* Attach SFP bus on combo port*/ /* Attach SFP bus on combo port*/
if (phy_read(phydev, QCA807X_CHIP_CONFIGURATION)) { if (phy_read(phydev, QCA807X_CHIP_CONFIGURATION)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment