Commit 1704b26e authored by Jean Delvare's avatar Jean Delvare

hwmon: (w83627ehf) Invert fan pin variables logic

Use positive logic for fan pin variables (variable is set if pin is
used for fan), instead of negative logic which is error prone.
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: Gong Jun <JGong@nuvoton.com>
parent b6a33fe2
...@@ -1317,8 +1317,8 @@ static int __devinit w83627ehf_probe(struct platform_device *pdev) ...@@ -1317,8 +1317,8 @@ static int __devinit w83627ehf_probe(struct platform_device *pdev)
/* fan4 and fan5 share some pins with the GPIO and serial flash */ /* fan4 and fan5 share some pins with the GPIO and serial flash */
fan5pin = superio_inb(sio_data->sioreg, 0x24) & 0x2; fan5pin = !(superio_inb(sio_data->sioreg, 0x24) & 0x2);
fan4pin = superio_inb(sio_data->sioreg, 0x29) & 0x6; fan4pin = !(superio_inb(sio_data->sioreg, 0x29) & 0x6);
superio_exit(sio_data->sioreg); superio_exit(sio_data->sioreg);
/* It looks like fan4 and fan5 pins can be alternatively used /* It looks like fan4 and fan5 pins can be alternatively used
...@@ -1329,9 +1329,9 @@ static int __devinit w83627ehf_probe(struct platform_device *pdev) ...@@ -1329,9 +1329,9 @@ static int __devinit w83627ehf_probe(struct platform_device *pdev)
data->has_fan = 0x07; /* fan1, fan2 and fan3 */ data->has_fan = 0x07; /* fan1, fan2 and fan3 */
i = w83627ehf_read_value(data, W83627EHF_REG_FANDIV1); i = w83627ehf_read_value(data, W83627EHF_REG_FANDIV1);
if ((i & (1 << 2)) && (!fan4pin)) if ((i & (1 << 2)) && fan4pin)
data->has_fan |= (1 << 3); data->has_fan |= (1 << 3);
if (!(i & (1 << 1)) && (!fan5pin)) if (!(i & (1 << 1)) && fan5pin)
data->has_fan |= (1 << 4); data->has_fan |= (1 << 4);
/* Read fan clock dividers immediately */ /* Read fan clock dividers immediately */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment