Commit 1754c4f6 authored by Nicolai Stange's avatar Nicolai Stange Committed by Kalle Valo

libertas: make lbs_ibss_join_existing() return error code on rates overflow

Commit e5e884b4 ("libertas: Fix two buffer overflows at parsing bss
descriptor") introduced a bounds check on the number of supplied rates to
lbs_ibss_join_existing() and made it to return on overflow.

However, the aforementioned commit doesn't set the return value accordingly
and thus, lbs_ibss_join_existing() would return with zero even though it
failed.

Make lbs_ibss_join_existing return -EINVAL in case the bounds check on the
number of supplied rates fails.

Fixes: e5e884b4 ("libertas: Fix two buffer overflows at parsing bss descriptor")
Signed-off-by: default avatarNicolai Stange <nstange@suse.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent c7bf1fb7
......@@ -1786,6 +1786,7 @@ static int lbs_ibss_join_existing(struct lbs_private *priv,
if (rates_max > MAX_RATES) {
lbs_deb_join("invalid rates");
rcu_read_unlock();
ret = -EINVAL;
goto out;
}
rates = cmd.bss.rates;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment