Skip to content

L
linux
Commit 185352ae authored by Paulo Alcantara (SUSE)'s avatar Paulo Alcantara (SUSE) Committed by Steve French
Browse files
Options

cifs: Clean up DFS referral cache 

Do some renaming and code cleanup.

No functional changes.
Signed-off-by: default avatarPaulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: default avatarAurelien Aptel <aaptel@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 6629400a
Hide whitespace changes
Inline Side-by-side
Showing with 279 additions and 286 deletions
fs/cifs/dfs_cache.c
View file @ 185352ae
...@@ -22,60 +22,59 @@ ...@@ -22,60 +22,59 @@
#include "dfs_cache.h" #include "dfs_cache.h"
#define DFS_CACHE_HTABLE_SIZE 32 #define CACHE_HTABLE_SIZE 32
#define DFS_CACHE_MAX_ENTRIES 64 #define CACHE_MAX_ENTRIES 64
#define IS_INTERLINK_SET(v) ((v) & (DFSREF_REFERRAL_SERVER | \ #define IS_INTERLINK_SET(v) ((v) & (DFSREF_REFERRAL_SERVER | \
DFSREF_STORAGE_SERVER)) DFSREF_STORAGE_SERVER))
struct dfs_cache_tgt { struct cache_dfs_tgt {
char *t_name; char *name;
struct list_head t_list; struct list_head list;
}; };
struct dfs_cache_entry { struct cache_entry {
struct hlist_node ce_hlist; struct hlist_node hlist;
const char *ce_path; const char *path;
int ce_ttl; int ttl;
int ce_srvtype; int srvtype;
int ce_flags; int flags;
struct timespec64 ce_etime; struct timespec64 etime;
int ce_path_consumed; int path_consumed;
int ce_numtgts; int numtgts;
struct list_head ce_tlist; struct list_head tlist;
struct dfs_cache_tgt *ce_tgthint; struct cache_dfs_tgt *tgthint;
struct rcu_head ce_rcu; struct rcu_head rcu;
}; };
static struct kmem_cache *dfs_cache_slab __read_mostly; struct vol_info {
char *fullpath;
struct dfs_cache_vol_info { struct smb_vol smb_vol;
char *vi_fullpath; char *mntdata;
struct smb_vol vi_vol; struct list_head list;
char *vi_mntdata;
struct list_head vi_list;
}; };
struct dfs_cache { static struct kmem_cache *cache_slab __read_mostly;
struct mutex dc_lock; static struct workqueue_struct *dfscache_wq __read_mostly;
struct nls_table *dc_nlsc;
struct list_head dc_vol_list;
int dc_ttl;
struct delayed_work dc_refresh;
};
static struct dfs_cache dfs_cache; static int cache_ttl;
static struct nls_table *cache_nlsc;
/* /*
* Number of entries in the cache * Number of entries in the cache
*/ */
static size_t dfs_cache_count; static size_t cache_count;
static struct hlist_head cache_htable[CACHE_HTABLE_SIZE];
static DEFINE_MUTEX(list_lock);
static DEFINE_MUTEX(dfs_cache_list_lock); static LIST_HEAD(vol_list);
static struct hlist_head dfs_cache_htable[DFS_CACHE_HTABLE_SIZE]; static DEFINE_MUTEX(vol_lock);
static void refresh_cache_worker(struct work_struct *work); static void refresh_cache_worker(struct work_struct *work);
static DECLARE_DELAYED_WORK(refresh_task, refresh_cache_worker);
static inline bool is_path_valid(const char *path) static inline bool is_path_valid(const char *path)
{ {
return path && (strchr(path + 1, '\\') || strchr(path + 1, '/')); return path && (strchr(path + 1, '\\') || strchr(path + 1, '/'));
...@@ -100,42 +99,42 @@ static inline void free_normalized_path(const char *path, char *npath) ...@@ -100,42 +99,42 @@ static inline void free_normalized_path(const char *path, char *npath)
kfree(npath); kfree(npath);
} }
static inline bool cache_entry_expired(const struct dfs_cache_entry *ce) static inline bool cache_entry_expired(const struct cache_entry *ce)
{ {
struct timespec64 ts; struct timespec64 ts;
ktime_get_coarse_real_ts64(&ts); ktime_get_coarse_real_ts64(&ts);
return timespec64_compare(&ts, &ce->ce_etime) >= 0; return timespec64_compare(&ts, &ce->etime) >= 0;
} }
static inline void free_tgts(struct dfs_cache_entry *ce) static inline void free_tgts(struct cache_entry *ce)
{ {
struct dfs_cache_tgt *t, *n; struct cache_dfs_tgt *t, *n;
list_for_each_entry_safe(t, n, &ce->ce_tlist, t_list) { list_for_each_entry_safe(t, n, &ce->tlist, list) {
list_del(&t->t_list); list_del(&t->list);
kfree(t->t_name); kfree(t->name);
kfree(t); kfree(t);
} }
} }
static void free_cache_entry(struct rcu_head *rcu) static void free_cache_entry(struct rcu_head *rcu)
{ {
struct dfs_cache_entry *ce = container_of(rcu, struct dfs_cache_entry, struct cache_entry *ce = container_of(rcu, struct cache_entry, rcu);
ce_rcu);
kmem_cache_free(dfs_cache_slab, ce); kmem_cache_free(cache_slab, ce);
} }
static inline void flush_cache_ent(struct dfs_cache_entry *ce) static inline void flush_cache_ent(struct cache_entry *ce)
{ {
if (hlist_unhashed(&ce->ce_hlist)) if (hlist_unhashed(&ce->hlist))
return; return;
hlist_del_init_rcu(&ce->ce_hlist); hlist_del_init_rcu(&ce->hlist);
kfree_const(ce->ce_path); kfree_const(ce->path);
free_tgts(ce); free_tgts(ce);
dfs_cache_count--; cache_count--;
call_rcu(&ce->ce_rcu, free_cache_entry); call_rcu(&ce->rcu, free_cache_entry);
} }
static void flush_cache_ents(void) static void flush_cache_ents(void)
...@@ -143,11 +142,11 @@ static void flush_cache_ents(void) ...@@ -143,11 +142,11 @@ static void flush_cache_ents(void)
int i; int i;
rcu_read_lock(); rcu_read_lock();
for (i = 0; i < DFS_CACHE_HTABLE_SIZE; i++) { for (i = 0; i < CACHE_HTABLE_SIZE; i++) {
struct hlist_head *l = &dfs_cache_htable[i]; struct hlist_head *l = &cache_htable[i];
struct dfs_cache_entry *ce; struct cache_entry *ce;
hlist_for_each_entry_rcu(ce, l, ce_hlist) hlist_for_each_entry_rcu(ce, l, hlist)
flush_cache_ent(ce); flush_cache_ent(ce);
} }
rcu_read_unlock(); rcu_read_unlock();
...@@ -159,35 +158,35 @@ static void flush_cache_ents(void) ...@@ -159,35 +158,35 @@ static void flush_cache_ents(void)
static int dfscache_proc_show(struct seq_file *m, void *v) static int dfscache_proc_show(struct seq_file *m, void *v)
{ {
int bucket; int bucket;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
seq_puts(m, "DFS cache\n---------\n"); seq_puts(m, "DFS cache\n---------\n");
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
rcu_read_lock(); rcu_read_lock();
hash_for_each_rcu(dfs_cache_htable, bucket, ce, ce_hlist) { hash_for_each_rcu(cache_htable, bucket, ce, hlist) {
seq_printf(m, seq_printf(m,
"cache entry: path=%s,type=%s,ttl=%d,etime=%ld," "cache entry: path=%s,type=%s,ttl=%d,etime=%ld,"
"interlink=%s,path_consumed=%d,expired=%s\n", "interlink=%s,path_consumed=%d,expired=%s\n",
ce->ce_path, ce->path,
ce->ce_srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->srvtype == DFS_TYPE_ROOT ? "root" : "link",
ce->ce_ttl, ce->ce_etime.tv_nsec, ce->ttl, ce->etime.tv_nsec,
IS_INTERLINK_SET(ce->ce_flags) ? "yes" : "no", IS_INTERLINK_SET(ce->flags) ? "yes" : "no",
ce->ce_path_consumed, ce->path_consumed,
cache_entry_expired(ce) ? "yes" : "no"); cache_entry_expired(ce) ? "yes" : "no");
list_for_each_entry(t, &ce->ce_tlist, t_list) { list_for_each_entry(t, &ce->tlist, list) {
seq_printf(m, " %s%s\n", seq_printf(m, " %s%s\n",
t->t_name, t->name,
ce->ce_tgthint == t ? " (target hint)" : ""); ce->tgthint == t ? " (target hint)" : "");
} }
} }
rcu_read_unlock(); rcu_read_unlock();
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
return 0; return 0;
} }
...@@ -205,9 +204,9 @@ static ssize_t dfscache_proc_write(struct file *file, const char __user *buffer, ...@@ -205,9 +204,9 @@ static ssize_t dfscache_proc_write(struct file *file, const char __user *buffer,
return -EINVAL; return -EINVAL;
cifs_dbg(FYI, "clearing dfs cache"); cifs_dbg(FYI, "clearing dfs cache");
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
flush_cache_ents(); flush_cache_ents();
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
return count; return count;
} }
...@@ -226,25 +225,25 @@ const struct file_operations dfscache_proc_fops = { ...@@ -226,25 +225,25 @@ const struct file_operations dfscache_proc_fops = {
}; };
#ifdef CONFIG_CIFS_DEBUG2 #ifdef CONFIG_CIFS_DEBUG2
static inline void dump_tgts(const struct dfs_cache_entry *ce) static inline void dump_tgts(const struct cache_entry *ce)
{ {
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
cifs_dbg(FYI, "target list:\n"); cifs_dbg(FYI, "target list:\n");
list_for_each_entry(t, &ce->ce_tlist, t_list) { list_for_each_entry(t, &ce->tlist, list) {
cifs_dbg(FYI, " %s%s\n", t->t_name, cifs_dbg(FYI, " %s%s\n", t->name,
ce->ce_tgthint == t ? " (target hint)" : ""); ce->tgthint == t ? " (target hint)" : "");
} }
} }
static inline void dump_ce(const struct dfs_cache_entry *ce) static inline void dump_ce(const struct cache_entry *ce)
{ {
cifs_dbg(FYI, "cache entry: path=%s,type=%s,ttl=%d,etime=%ld," cifs_dbg(FYI, "cache entry: path=%s,type=%s,ttl=%d,etime=%ld,"
"interlink=%s,path_consumed=%d,expired=%s\n", ce->ce_path, "interlink=%s,path_consumed=%d,expired=%s\n", ce->path,
ce->ce_srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ce_ttl, ce->srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ttl,
ce->ce_etime.tv_nsec, ce->etime.tv_nsec,
IS_INTERLINK_SET(ce->ce_flags) ? "yes" : "no", IS_INTERLINK_SET(ce->flags) ? "yes" : "no",
ce->ce_path_consumed, ce->path_consumed,
cache_entry_expired(ce) ? "yes" : "no"); cache_entry_expired(ce) ? "yes" : "no");
dump_tgts(ce); dump_tgts(ce);
} }
...@@ -284,25 +283,34 @@ static inline void dump_refs(const struct dfs_info3_param *refs, int numrefs) ...@@ -284,25 +283,34 @@ static inline void dump_refs(const struct dfs_info3_param *refs, int numrefs)
*/ */
int dfs_cache_init(void) int dfs_cache_init(void)
{ {
int rc;
int i; int i;
dfs_cache_slab = kmem_cache_create("cifs_dfs_cache", dfscache_wq = alloc_workqueue("cifs-dfscache",
sizeof(struct dfs_cache_entry), 0, WQ_FREEZABLE | WQ_MEM_RECLAIM, 1);
SLAB_HWCACHE_ALIGN, NULL); if (!dfscache_wq)
if (!dfs_cache_slab)
return -ENOMEM; return -ENOMEM;
for (i = 0; i < DFS_CACHE_HTABLE_SIZE; i++) cache_slab = kmem_cache_create("cifs_dfs_cache",
INIT_HLIST_HEAD(&dfs_cache_htable[i]); sizeof(struct cache_entry), 0,
SLAB_HWCACHE_ALIGN, NULL);
if (!cache_slab) {
rc = -ENOMEM;
goto out_destroy_wq;
}
for (i = 0; i < CACHE_HTABLE_SIZE; i++)
INIT_HLIST_HEAD(&cache_htable[i]);
INIT_LIST_HEAD(&dfs_cache.dc_vol_list); cache_ttl = -1;
mutex_init(&dfs_cache.dc_lock); cache_nlsc = load_nls_default();
INIT_DELAYED_WORK(&dfs_cache.dc_refresh, refresh_cache_worker);
dfs_cache.dc_ttl = -1;
dfs_cache.dc_nlsc = load_nls_default();
cifs_dbg(FYI, "%s: initialized DFS referral cache\n", __func__); cifs_dbg(FYI, "%s: initialized DFS referral cache\n", __func__);
return 0; return 0;
out_destroy_wq:
destroy_workqueue(dfscache_wq);
return rc;
} }
static inline unsigned int cache_entry_hash(const void *data, int size) static inline unsigned int cache_entry_hash(const void *data, int size)
...@@ -310,7 +318,7 @@ static inline unsigned int cache_entry_hash(const void *data, int size) ...@@ -310,7 +318,7 @@ static inline unsigned int cache_entry_hash(const void *data, int size)
unsigned int h; unsigned int h;
h = jhash(data, size, 0); h = jhash(data, size, 0);
return h & (DFS_CACHE_HTABLE_SIZE - 1); return h & (CACHE_HTABLE_SIZE - 1);
} }
/* Check whether second path component of @path is SYSVOL or NETLOGON */ /* Check whether second path component of @path is SYSVOL or NETLOGON */
...@@ -325,11 +333,11 @@ static inline bool is_sysvol_or_netlogon(const char *path) ...@@ -325,11 +333,11 @@ static inline bool is_sysvol_or_netlogon(const char *path)
} }
/* Return target hint of a DFS cache entry */ /* Return target hint of a DFS cache entry */
static inline char *get_tgt_name(const struct dfs_cache_entry *ce) static inline char *get_tgt_name(const struct cache_entry *ce)
{ {
struct dfs_cache_tgt *t = ce->ce_tgthint; struct cache_dfs_tgt *t = ce->tgthint;
return t ? t->t_name : ERR_PTR(-ENOENT); return t ? t->name : ERR_PTR(-ENOENT);
} }
/* Return expire time out of a new entry's TTL */ /* Return expire time out of a new entry's TTL */
...@@ -346,19 +354,19 @@ static inline struct timespec64 get_expire_time(int ttl) ...@@ -346,19 +354,19 @@ static inline struct timespec64 get_expire_time(int ttl)
} }
/* Allocate a new DFS target */ /* Allocate a new DFS target */
static inline struct dfs_cache_tgt *alloc_tgt(const char *name) static inline struct cache_dfs_tgt *alloc_tgt(const char *name)
{ {
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
t = kmalloc(sizeof(*t), GFP_KERNEL); t = kmalloc(sizeof(*t), GFP_KERNEL);
if (!t) if (!t)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
t->t_name = kstrndup(name, strlen(name), GFP_KERNEL); t->name = kstrndup(name, strlen(name), GFP_KERNEL);
if (!t->t_name) { if (!t->name) {
kfree(t); kfree(t);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
INIT_LIST_HEAD(&t->t_list); INIT_LIST_HEAD(&t->list);
return t; return t;
} }
...@@ -367,63 +375,63 @@ static inline struct dfs_cache_tgt *alloc_tgt(const char *name) ...@@ -367,63 +375,63 @@ static inline struct dfs_cache_tgt *alloc_tgt(const char *name)
* target hint. * target hint.
*/ */
static int copy_ref_data(const struct dfs_info3_param *refs, int numrefs, static int copy_ref_data(const struct dfs_info3_param *refs, int numrefs,
struct dfs_cache_entry *ce, const char *tgthint) struct cache_entry *ce, const char *tgthint)
{ {
int i; int i;
ce->ce_ttl = refs[0].ttl; ce->ttl = refs[0].ttl;
ce->ce_etime = get_expire_time(ce->ce_ttl); ce->etime = get_expire_time(ce->ttl);
ce->ce_srvtype = refs[0].server_type; ce->srvtype = refs[0].server_type;
ce->ce_flags = refs[0].ref_flag; ce->flags = refs[0].ref_flag;
ce->ce_path_consumed = refs[0].path_consumed; ce->path_consumed = refs[0].path_consumed;
for (i = 0; i < numrefs; i++) { for (i = 0; i < numrefs; i++) {
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
t = alloc_tgt(refs[i].node_name); t = alloc_tgt(refs[i].node_name);
if (IS_ERR(t)) { if (IS_ERR(t)) {
free_tgts(ce); free_tgts(ce);
return PTR_ERR(t); return PTR_ERR(t);
} }
if (tgthint && !strcasecmp(t->t_name, tgthint)) { if (tgthint && !strcasecmp(t->name, tgthint)) {
list_add(&t->t_list, &ce->ce_tlist); list_add(&t->list, &ce->tlist);
tgthint = NULL; tgthint = NULL;
} else { } else {
list_add_tail(&t->t_list, &ce->ce_tlist); list_add_tail(&t->list, &ce->tlist);
} }
ce->ce_numtgts++; ce->numtgts++;
} }
ce->ce_tgthint = list_first_entry_or_null(&ce->ce_tlist, ce->tgthint = list_first_entry_or_null(&ce->tlist,
struct dfs_cache_tgt, t_list); struct cache_dfs_tgt, list);
return 0; return 0;
} }
/* Allocate a new cache entry */ /* Allocate a new cache entry */
static struct dfs_cache_entry * static struct cache_entry *alloc_cache_entry(const char *path,
alloc_cache_entry(const char *path, const struct dfs_info3_param *refs, const struct dfs_info3_param *refs,
int numrefs) int numrefs)
{ {
struct dfs_cache_entry *ce; struct cache_entry *ce;
int rc; int rc;
ce = kmem_cache_zalloc(dfs_cache_slab, GFP_KERNEL); ce = kmem_cache_zalloc(cache_slab, GFP_KERNEL);
if (!ce) if (!ce)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
ce->ce_path = kstrdup_const(path, GFP_KERNEL); ce->path = kstrdup_const(path, GFP_KERNEL);
if (!ce->ce_path) { if (!ce->path) {
kmem_cache_free(dfs_cache_slab, ce); kmem_cache_free(cache_slab, ce);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
INIT_HLIST_NODE(&ce->ce_hlist); INIT_HLIST_NODE(&ce->hlist);
INIT_LIST_HEAD(&ce->ce_tlist); INIT_LIST_HEAD(&ce->tlist);
rc = copy_ref_data(refs, numrefs, ce, NULL); rc = copy_ref_data(refs, numrefs, ce, NULL);
if (rc) { if (rc) {
kfree_const(ce->ce_path); kfree_const(ce->path);
kmem_cache_free(dfs_cache_slab, ce); kmem_cache_free(cache_slab, ce);
ce = ERR_PTR(rc); ce = ERR_PTR(rc);
} }
return ce; return ce;
...@@ -432,13 +440,13 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs, ...@@ -432,13 +440,13 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs,
static void remove_oldest_entry(void) static void remove_oldest_entry(void)
{ {
int bucket; int bucket;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_cache_entry *to_del = NULL; struct cache_entry *to_del = NULL;
rcu_read_lock(); rcu_read_lock();
hash_for_each_rcu(dfs_cache_htable, bucket, ce, ce_hlist) { hash_for_each_rcu(cache_htable, bucket, ce, hlist) {
if (!to_del || timespec64_compare(&ce->ce_etime, if (!to_del || timespec64_compare(&ce->etime,
&to_del->ce_etime) < 0) &to_del->etime) < 0)
to_del = ce; to_del = ce;
} }
if (!to_del) { if (!to_del) {
...@@ -453,93 +461,84 @@ static void remove_oldest_entry(void) ...@@ -453,93 +461,84 @@ static void remove_oldest_entry(void)
} }
/* Add a new DFS cache entry */ /* Add a new DFS cache entry */
static inline struct dfs_cache_entry * static inline struct cache_entry *
add_cache_entry(unsigned int hash, const char *path, add_cache_entry(unsigned int hash, const char *path,
const struct dfs_info3_param *refs, int numrefs) const struct dfs_info3_param *refs, int numrefs)
{ {
struct dfs_cache_entry *ce; struct cache_entry *ce;
ce = alloc_cache_entry(path, refs, numrefs); ce = alloc_cache_entry(path, refs, numrefs);
if (IS_ERR(ce)) if (IS_ERR(ce))
return ce; return ce;
hlist_add_head_rcu(&ce->ce_hlist, &dfs_cache_htable[hash]); hlist_add_head_rcu(&ce->hlist, &cache_htable[hash]);
mutex_lock(&dfs_cache.dc_lock); mutex_lock(&vol_lock);
if (dfs_cache.dc_ttl < 0) { if (cache_ttl < 0) {
dfs_cache.dc_ttl = ce->ce_ttl; cache_ttl = ce->ttl;
queue_delayed_work(cifsiod_wq, &dfs_cache.dc_refresh, queue_delayed_work(dfscache_wq, &refresh_task, cache_ttl * HZ);
dfs_cache.dc_ttl * HZ);
} else { } else {
dfs_cache.dc_ttl = min_t(int, dfs_cache.dc_ttl, ce->ce_ttl); cache_ttl = min_t(int, cache_ttl, ce->ttl);
mod_delayed_work(cifsiod_wq, &dfs_cache.dc_refresh, mod_delayed_work(dfscache_wq, &refresh_task, cache_ttl * HZ);
dfs_cache.dc_ttl * HZ);
} }
mutex_unlock(&dfs_cache.dc_lock); mutex_unlock(&vol_lock);
return ce; return ce;
} }
static struct dfs_cache_entry *__find_cache_entry(unsigned int hash, /*
const char *path) * Find a DFS cache entry in hash table and optionally check prefix path against
* @path.
* Use whole path components in the match.
* Return ERR_PTR(-ENOENT) if the entry is not found.
*/
static struct cache_entry *lookup_cache_entry(const char *path,
unsigned int *hash)
{ {
struct dfs_cache_entry *ce; struct cache_entry *ce;
unsigned int h;
bool found = false; bool found = false;
rcu_read_lock(); h = cache_entry_hash(path, strlen(path));
hlist_for_each_entry_rcu(ce, &dfs_cache_htable[hash], ce_hlist) {
if (!strcasecmp(path, ce->ce_path)) {
#ifdef CONFIG_CIFS_DEBUG2
char *name = get_tgt_name(ce);
if (IS_ERR(name)) { rcu_read_lock();
rcu_read_unlock(); hlist_for_each_entry_rcu(ce, &cache_htable[h], hlist) {
return ERR_CAST(name); if (!strcasecmp(path, ce->path)) {
}
cifs_dbg(FYI, "%s: cache hit\n", __func__);
cifs_dbg(FYI, "%s: target hint: %s\n", __func__, name);
#endif
found = true; found = true;
dump_ce(ce);
break; break;
} }
} }
rcu_read_unlock(); rcu_read_unlock();
return found ? ce : ERR_PTR(-ENOENT);
}
/* if (!found)
* Find a DFS cache entry in hash table and optionally check prefix path against ce = ERR_PTR(-ENOENT);
* @path. if (hash)
* Use whole path components in the match. *hash = h;
* Return ERR_PTR(-ENOENT) if the entry is not found.
*/ return ce;
static inline struct dfs_cache_entry *find_cache_entry(const char *path,
unsigned int *hash)
{
*hash = cache_entry_hash(path, strlen(path));
return __find_cache_entry(*hash, path);
} }
static inline void destroy_slab_cache(void) static inline void destroy_slab_cache(void)
{ {
rcu_barrier(); rcu_barrier();
kmem_cache_destroy(dfs_cache_slab); kmem_cache_destroy(cache_slab);
} }
static inline void free_vol(struct dfs_cache_vol_info *vi) static inline void free_vol(struct vol_info *vi)
{ {
list_del(&vi->vi_list); list_del(&vi->list);
kfree(vi->vi_fullpath); kfree(vi->fullpath);
kfree(vi->vi_mntdata); kfree(vi->mntdata);
cifs_cleanup_volume_info_contents(&vi->vi_vol); cifs_cleanup_volume_info_contents(&vi->smb_vol);
kfree(vi); kfree(vi);
} }
static inline void free_vol_list(void) static inline void free_vol_list(void)
{ {
struct dfs_cache_vol_info *vi, *nvi; struct vol_info *vi, *nvi;
list_for_each_entry_safe(vi, nvi, &dfs_cache.dc_vol_list, vi_list) list_for_each_entry_safe(vi, nvi, &vol_list, list)
free_vol(vi); free_vol(vi);
} }
...@@ -548,40 +547,38 @@ static inline void free_vol_list(void) ...@@ -548,40 +547,38 @@ static inline void free_vol_list(void)
*/ */
void dfs_cache_destroy(void) void dfs_cache_destroy(void)
{ {
cancel_delayed_work_sync(&dfs_cache.dc_refresh); cancel_delayed_work_sync(&refresh_task);
unload_nls(dfs_cache.dc_nlsc); unload_nls(cache_nlsc);
free_vol_list(); free_vol_list();
mutex_destroy(&dfs_cache.dc_lock);
flush_cache_ents(); flush_cache_ents();
destroy_slab_cache(); destroy_slab_cache();
mutex_destroy(&dfs_cache_list_lock); destroy_workqueue(dfscache_wq);
cifs_dbg(FYI, "%s: destroyed DFS referral cache\n", __func__); cifs_dbg(FYI, "%s: destroyed DFS referral cache\n", __func__);
} }
static inline struct dfs_cache_entry * static inline struct cache_entry *
__update_cache_entry(const char *path, const struct dfs_info3_param *refs, __update_cache_entry(const char *path, const struct dfs_info3_param *refs,
int numrefs) int numrefs)
{ {
int rc; int rc;
unsigned int h; unsigned int h;
struct dfs_cache_entry *ce; struct cache_entry *ce;
char *s, *th = NULL; char *s, *th = NULL;
ce = find_cache_entry(path, &h); ce = lookup_cache_entry(path, &h);
if (IS_ERR(ce)) if (IS_ERR(ce))
return ce; return ce;
if (ce->ce_tgthint) { if (ce->tgthint) {
s = ce->ce_tgthint->t_name; s = ce->tgthint->name;
th = kstrndup(s, strlen(s), GFP_KERNEL); th = kstrndup(s, strlen(s), GFP_KERNEL);
if (!th) if (!th)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
free_tgts(ce); free_tgts(ce);
ce->ce_numtgts = 0; ce->numtgts = 0;
rc = copy_ref_data(refs, numrefs, ce, th); rc = copy_ref_data(refs, numrefs, ce, th);
kfree(th); kfree(th);
...@@ -593,10 +590,10 @@ __update_cache_entry(const char *path, const struct dfs_info3_param *refs, ...@@ -593,10 +590,10 @@ __update_cache_entry(const char *path, const struct dfs_info3_param *refs,
} }
/* Update an expired cache entry by getting a new DFS referral from server */ /* Update an expired cache entry by getting a new DFS referral from server */
static struct dfs_cache_entry * static struct cache_entry *
update_cache_entry(const unsigned int xid, struct cifs_ses *ses, update_cache_entry(const unsigned int xid, struct cifs_ses *ses,
const struct nls_table *nls_codepage, int remap, const struct nls_table *nls_codepage, int remap,
const char *path, struct dfs_cache_entry *ce) const char *path, struct cache_entry *ce)
{ {
int rc; int rc;
struct dfs_info3_param *refs = NULL; struct dfs_info3_param *refs = NULL;
...@@ -636,20 +633,20 @@ update_cache_entry(const unsigned int xid, struct cifs_ses *ses, ...@@ -636,20 +633,20 @@ update_cache_entry(const unsigned int xid, struct cifs_ses *ses,
* For interlinks, __cifs_dfs_mount() and expand_dfs_referral() are supposed to * For interlinks, __cifs_dfs_mount() and expand_dfs_referral() are supposed to
* handle them properly. * handle them properly.
*/ */
static struct dfs_cache_entry * static struct cache_entry *
do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
const struct nls_table *nls_codepage, int remap, const struct nls_table *nls_codepage, int remap,
const char *path, bool noreq) const char *path, bool noreq)
{ {
int rc; int rc;
unsigned int h; unsigned int h;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_info3_param *nrefs; struct dfs_info3_param *nrefs;
int numnrefs; int numnrefs;
cifs_dbg(FYI, "%s: search path: %s\n", __func__, path); cifs_dbg(FYI, "%s: search path: %s\n", __func__, path);
ce = find_cache_entry(path, &h); ce = lookup_cache_entry(path, &h);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
cifs_dbg(FYI, "%s: cache miss\n", __func__); cifs_dbg(FYI, "%s: cache miss\n", __func__);
/* /*
...@@ -690,9 +687,9 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -690,9 +687,9 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
cifs_dbg(FYI, "%s: new cache entry\n", __func__); cifs_dbg(FYI, "%s: new cache entry\n", __func__);
if (dfs_cache_count >= DFS_CACHE_MAX_ENTRIES) { if (cache_count >= CACHE_MAX_ENTRIES) {
cifs_dbg(FYI, "%s: reached max cache size (%d)", cifs_dbg(FYI, "%s: reached max cache size (%d)",
__func__, DFS_CACHE_MAX_ENTRIES); __func__, CACHE_MAX_ENTRIES);
remove_oldest_entry(); remove_oldest_entry();
} }
ce = add_cache_entry(h, path, nrefs, numnrefs); ce = add_cache_entry(h, path, nrefs, numnrefs);
...@@ -701,7 +698,7 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -701,7 +698,7 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
if (IS_ERR(ce)) if (IS_ERR(ce))
return ce; return ce;
dfs_cache_count++; cache_count++;
} }
dump_ce(ce); dump_ce(ce);
...@@ -723,7 +720,7 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -723,7 +720,7 @@ do_dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
} }
/* Set up a new DFS referral from a given cache entry */ /* Set up a new DFS referral from a given cache entry */
static int setup_ref(const char *path, const struct dfs_cache_entry *ce, static int setup_ref(const char *path, const struct cache_entry *ce,
struct dfs_info3_param *ref, const char *tgt) struct dfs_info3_param *ref, const char *tgt)
{ {
int rc; int rc;
...@@ -736,7 +733,7 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce, ...@@ -736,7 +733,7 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce,
if (!ref->path_name) if (!ref->path_name)
return -ENOMEM; return -ENOMEM;
ref->path_consumed = ce->ce_path_consumed; ref->path_consumed = ce->path_consumed;
ref->node_name = kstrndup(tgt, strlen(tgt), GFP_KERNEL); ref->node_name = kstrndup(tgt, strlen(tgt), GFP_KERNEL);
if (!ref->node_name) { if (!ref->node_name) {
...@@ -744,9 +741,9 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce, ...@@ -744,9 +741,9 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce,
goto err_free_path; goto err_free_path;
} }
ref->ttl = ce->ce_ttl; ref->ttl = ce->ttl;
ref->server_type = ce->ce_srvtype; ref->server_type = ce->srvtype;
ref->ref_flag = ce->ce_flags; ref->ref_flag = ce->flags;
return 0; return 0;
...@@ -757,25 +754,25 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce, ...@@ -757,25 +754,25 @@ static int setup_ref(const char *path, const struct dfs_cache_entry *ce,
} }
/* Return target list of a DFS cache entry */ /* Return target list of a DFS cache entry */
static int get_tgt_list(const struct dfs_cache_entry *ce, static int get_tgt_list(const struct cache_entry *ce,
struct dfs_cache_tgt_list *tl) struct dfs_cache_tgt_list *tl)
{ {
int rc; int rc;
struct list_head *head = &tl->tl_list; struct list_head *head = &tl->tl_list;
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
struct dfs_cache_tgt_iterator *it, *nit; struct dfs_cache_tgt_iterator *it, *nit;
memset(tl, 0, sizeof(*tl)); memset(tl, 0, sizeof(*tl));
INIT_LIST_HEAD(head); INIT_LIST_HEAD(head);
list_for_each_entry(t, &ce->ce_tlist, t_list) { list_for_each_entry(t, &ce->tlist, list) {
it = kzalloc(sizeof(*it), GFP_KERNEL); it = kzalloc(sizeof(*it), GFP_KERNEL);
if (!it) { if (!it) {
rc = -ENOMEM; rc = -ENOMEM;
goto err_free_it; goto err_free_it;
} }
it->it_name = kstrndup(t->t_name, strlen(t->t_name), it->it_name = kstrndup(t->name, strlen(t->name),
GFP_KERNEL); GFP_KERNEL);
if (!it->it_name) { if (!it->it_name) {
kfree(it); kfree(it);
...@@ -783,12 +780,12 @@ static int get_tgt_list(const struct dfs_cache_entry *ce, ...@@ -783,12 +780,12 @@ static int get_tgt_list(const struct dfs_cache_entry *ce,
goto err_free_it; goto err_free_it;
} }
if (ce->ce_tgthint == t) if (ce->tgthint == t)
list_add(&it->it_list, head); list_add(&it->it_list, head);
else else
list_add_tail(&it->it_list, head); list_add_tail(&it->it_list, head);
} }
tl->tl_numtgts = ce->ce_numtgts; tl->tl_numtgts = ce->numtgts;
return 0; return 0;
...@@ -829,7 +826,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -829,7 +826,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
{ {
int rc; int rc;
char *npath; char *npath;
struct dfs_cache_entry *ce; struct cache_entry *ce;
if (unlikely(!is_path_valid(path))) if (unlikely(!is_path_valid(path)))
return -EINVAL; return -EINVAL;
...@@ -838,7 +835,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -838,7 +835,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
if (rc) if (rc)
return rc; return rc;
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = do_dfs_cache_find(xid, ses, nls_codepage, remap, npath, false); ce = do_dfs_cache_find(xid, ses, nls_codepage, remap, npath, false);
if (!IS_ERR(ce)) { if (!IS_ERR(ce)) {
if (ref) if (ref)
...@@ -850,7 +847,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses, ...@@ -850,7 +847,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
} else { } else {
rc = PTR_ERR(ce); rc = PTR_ERR(ce);
} }
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
free_normalized_path(path, npath); free_normalized_path(path, npath);
return rc; return rc;
} }
...@@ -876,7 +873,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref, ...@@ -876,7 +873,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref,
{ {
int rc; int rc;
char *npath; char *npath;
struct dfs_cache_entry *ce; struct cache_entry *ce;
if (unlikely(!is_path_valid(path))) if (unlikely(!is_path_valid(path)))
return -EINVAL; return -EINVAL;
...@@ -885,7 +882,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref, ...@@ -885,7 +882,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref,
if (rc) if (rc)
return rc; return rc;
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = do_dfs_cache_find(0, NULL, NULL, 0, npath, true); ce = do_dfs_cache_find(0, NULL, NULL, 0, npath, true);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
rc = PTR_ERR(ce); rc = PTR_ERR(ce);
...@@ -899,7 +896,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref, ...@@ -899,7 +896,7 @@ int dfs_cache_noreq_find(const char *path, struct dfs_info3_param *ref,
if (!rc && tgt_list) if (!rc && tgt_list)
rc = get_tgt_list(ce, tgt_list); rc = get_tgt_list(ce, tgt_list);
out: out:
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
free_normalized_path(path, npath); free_normalized_path(path, npath);
return rc; return rc;
} }
...@@ -929,8 +926,8 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses, ...@@ -929,8 +926,8 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
{ {
int rc; int rc;
char *npath; char *npath;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
if (unlikely(!is_path_valid(path))) if (unlikely(!is_path_valid(path)))
return -EINVAL; return -EINVAL;
...@@ -941,7 +938,7 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses, ...@@ -941,7 +938,7 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
cifs_dbg(FYI, "%s: path: %s\n", __func__, npath); cifs_dbg(FYI, "%s: path: %s\n", __func__, npath);
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = do_dfs_cache_find(xid, ses, nls_codepage, remap, npath, false); ce = do_dfs_cache_find(xid, ses, nls_codepage, remap, npath, false);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
rc = PTR_ERR(ce); rc = PTR_ERR(ce);
...@@ -950,14 +947,14 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses, ...@@ -950,14 +947,14 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
rc = 0; rc = 0;
t = ce->ce_tgthint; t = ce->tgthint;
if (likely(!strcasecmp(it->it_name, t->t_name))) if (likely(!strcasecmp(it->it_name, t->name)))
goto out; goto out;
list_for_each_entry(t, &ce->ce_tlist, t_list) { list_for_each_entry(t, &ce->tlist, list) {
if (!strcasecmp(t->t_name, it->it_name)) { if (!strcasecmp(t->name, it->it_name)) {
ce->ce_tgthint = t; ce->tgthint = t;
cifs_dbg(FYI, "%s: new target hint: %s\n", __func__, cifs_dbg(FYI, "%s: new target hint: %s\n", __func__,
it->it_name); it->it_name);
break; break;
...@@ -965,7 +962,7 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses, ...@@ -965,7 +962,7 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
} }
out: out:
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
free_normalized_path(path, npath); free_normalized_path(path, npath);
return rc; return rc;
} }
...@@ -989,8 +986,8 @@ int dfs_cache_noreq_update_tgthint(const char *path, ...@@ -989,8 +986,8 @@ int dfs_cache_noreq_update_tgthint(const char *path,
{ {
int rc; int rc;
char *npath; char *npath;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_cache_tgt *t; struct cache_dfs_tgt *t;
if (unlikely(!is_path_valid(path)) || !it) if (unlikely(!is_path_valid(path)) || !it)
return -EINVAL; return -EINVAL;
...@@ -1001,7 +998,7 @@ int dfs_cache_noreq_update_tgthint(const char *path, ...@@ -1001,7 +998,7 @@ int dfs_cache_noreq_update_tgthint(const char *path,
cifs_dbg(FYI, "%s: path: %s\n", __func__, npath); cifs_dbg(FYI, "%s: path: %s\n", __func__, npath);
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = do_dfs_cache_find(0, NULL, NULL, 0, npath, true); ce = do_dfs_cache_find(0, NULL, NULL, 0, npath, true);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
...@@ -1011,14 +1008,14 @@ int dfs_cache_noreq_update_tgthint(const char *path, ...@@ -1011,14 +1008,14 @@ int dfs_cache_noreq_update_tgthint(const char *path,
rc = 0; rc = 0;
t = ce->ce_tgthint; t = ce->tgthint;
if (unlikely(!strcasecmp(it->it_name, t->t_name))) if (unlikely(!strcasecmp(it->it_name, t->name)))
goto out; goto out;
list_for_each_entry(t, &ce->ce_tlist, t_list) { list_for_each_entry(t, &ce->tlist, list) {
if (!strcasecmp(t->t_name, it->it_name)) { if (!strcasecmp(t->name, it->it_name)) {
ce->ce_tgthint = t; ce->tgthint = t;
cifs_dbg(FYI, "%s: new target hint: %s\n", __func__, cifs_dbg(FYI, "%s: new target hint: %s\n", __func__,
it->it_name); it->it_name);
break; break;
...@@ -1026,7 +1023,7 @@ int dfs_cache_noreq_update_tgthint(const char *path, ...@@ -1026,7 +1023,7 @@ int dfs_cache_noreq_update_tgthint(const char *path,
} }
out: out:
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
free_normalized_path(path, npath); free_normalized_path(path, npath);
return rc; return rc;
} }
...@@ -1047,7 +1044,7 @@ int dfs_cache_get_tgt_referral(const char *path, ...@@ -1047,7 +1044,7 @@ int dfs_cache_get_tgt_referral(const char *path,
{ {
int rc; int rc;
char *npath; char *npath;
struct dfs_cache_entry *ce; struct cache_entry *ce;
unsigned int h; unsigned int h;
if (!it || !ref) if (!it || !ref)
...@@ -1061,9 +1058,9 @@ int dfs_cache_get_tgt_referral(const char *path, ...@@ -1061,9 +1058,9 @@ int dfs_cache_get_tgt_referral(const char *path,
cifs_dbg(FYI, "%s: path: %s\n", __func__, npath); cifs_dbg(FYI, "%s: path: %s\n", __func__, npath);
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = find_cache_entry(npath, &h); ce = lookup_cache_entry(npath, &h);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
rc = PTR_ERR(ce); rc = PTR_ERR(ce);
goto out; goto out;
...@@ -1074,7 +1071,7 @@ int dfs_cache_get_tgt_referral(const char *path, ...@@ -1074,7 +1071,7 @@ int dfs_cache_get_tgt_referral(const char *path,
rc = setup_ref(path, ce, ref, it->it_name); rc = setup_ref(path, ce, ref, it->it_name);
out: out:
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
free_normalized_path(path, npath); free_normalized_path(path, npath);
return rc; return rc;
} }
...@@ -1085,7 +1082,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new) ...@@ -1085,7 +1082,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new)
if (vol->username) { if (vol->username) {
new->username = kstrndup(vol->username, strlen(vol->username), new->username = kstrndup(vol->username, strlen(vol->username),
GFP_KERNEL); GFP_KERNEL);
if (!new->username) if (!new->username)
return -ENOMEM; return -ENOMEM;
} }
...@@ -1103,7 +1100,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new) ...@@ -1103,7 +1100,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new)
} }
if (vol->domainname) { if (vol->domainname) {
new->domainname = kstrndup(vol->domainname, new->domainname = kstrndup(vol->domainname,
strlen(vol->domainname), GFP_KERNEL); strlen(vol->domainname), GFP_KERNEL);
if (!new->domainname) if (!new->domainname)
goto err_free_unc; goto err_free_unc;
} }
...@@ -1150,7 +1147,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new) ...@@ -1150,7 +1147,7 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new)
int dfs_cache_add_vol(char *mntdata, struct smb_vol *vol, const char *fullpath) int dfs_cache_add_vol(char *mntdata, struct smb_vol *vol, const char *fullpath)
{ {
int rc; int rc;
struct dfs_cache_vol_info *vi; struct vol_info *vi;
if (!vol || !fullpath || !mntdata) if (!vol || !fullpath || !mntdata)
return -EINVAL; return -EINVAL;
...@@ -1161,38 +1158,37 @@ int dfs_cache_add_vol(char *mntdata, struct smb_vol *vol, const char *fullpath) ...@@ -1161,38 +1158,37 @@ int dfs_cache_add_vol(char *mntdata, struct smb_vol *vol, const char *fullpath)
if (!vi) if (!vi)
return -ENOMEM; return -ENOMEM;
vi->vi_fullpath = kstrndup(fullpath, strlen(fullpath), GFP_KERNEL); vi->fullpath = kstrndup(fullpath, strlen(fullpath), GFP_KERNEL);
if (!vi->vi_fullpath) { if (!vi->fullpath) {
rc = -ENOMEM; rc = -ENOMEM;
goto err_free_vi; goto err_free_vi;
} }
rc = dup_vol(vol, &vi->vi_vol); rc = dup_vol(vol, &vi->smb_vol);
if (rc) if (rc)
goto err_free_fullpath; goto err_free_fullpath;
vi->vi_mntdata = mntdata; vi->mntdata = mntdata;
mutex_lock(&dfs_cache.dc_lock); mutex_lock(&vol_lock);
list_add_tail(&vi->vi_list, &dfs_cache.dc_vol_list); list_add_tail(&vi->list, &vol_list);
mutex_unlock(&dfs_cache.dc_lock); mutex_unlock(&vol_lock);
return 0; return 0;
err_free_fullpath: err_free_fullpath:
kfree(vi->vi_fullpath); kfree(vi->fullpath);
err_free_vi: err_free_vi:
kfree(vi); kfree(vi);
return rc; return rc;
} }
static inline struct dfs_cache_vol_info *find_vol(const char *fullpath) static inline struct vol_info *find_vol(const char *fullpath)
{ {
struct dfs_cache_vol_info *vi; struct vol_info *vi;
list_for_each_entry(vi, &dfs_cache.dc_vol_list, vi_list) { list_for_each_entry(vi, &vol_list, list) {
cifs_dbg(FYI, "%s: vi->vi_fullpath: %s\n", __func__, cifs_dbg(FYI, "%s: vi->fullpath: %s\n", __func__, vi->fullpath);
vi->vi_fullpath); if (!strcasecmp(vi->fullpath, fullpath))
if (!strcasecmp(vi->vi_fullpath, fullpath))
return vi; return vi;
} }
return ERR_PTR(-ENOENT); return ERR_PTR(-ENOENT);
...@@ -1209,14 +1205,14 @@ static inline struct dfs_cache_vol_info *find_vol(const char *fullpath) ...@@ -1209,14 +1205,14 @@ static inline struct dfs_cache_vol_info *find_vol(const char *fullpath)
int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server) int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server)
{ {
int rc; int rc;
struct dfs_cache_vol_info *vi; struct vol_info *vi;
if (!fullpath || !server) if (!fullpath || !server)
return -EINVAL; return -EINVAL;
cifs_dbg(FYI, "%s: fullpath: %s\n", __func__, fullpath); cifs_dbg(FYI, "%s: fullpath: %s\n", __func__, fullpath);
mutex_lock(&dfs_cache.dc_lock); mutex_lock(&vol_lock);
vi = find_vol(fullpath); vi = find_vol(fullpath);
if (IS_ERR(vi)) { if (IS_ERR(vi)) {
...@@ -1225,12 +1221,12 @@ int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server) ...@@ -1225,12 +1221,12 @@ int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server)
} }
cifs_dbg(FYI, "%s: updating volume info\n", __func__); cifs_dbg(FYI, "%s: updating volume info\n", __func__);
memcpy(&vi->vi_vol.dstaddr, &server->dstaddr, memcpy(&vi->smb_vol.dstaddr, &server->dstaddr,
sizeof(vi->vi_vol.dstaddr)); sizeof(vi->smb_vol.dstaddr));
rc = 0; rc = 0;
out: out:
mutex_unlock(&dfs_cache.dc_lock); mutex_unlock(&vol_lock);
return rc; return rc;
} }
...@@ -1241,18 +1237,18 @@ int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server) ...@@ -1241,18 +1237,18 @@ int dfs_cache_update_vol(const char *fullpath, struct TCP_Server_Info *server)
*/ */
void dfs_cache_del_vol(const char *fullpath) void dfs_cache_del_vol(const char *fullpath)
{ {
struct dfs_cache_vol_info *vi; struct vol_info *vi;
if (!fullpath || !*fullpath) if (!fullpath || !*fullpath)
return; return;
cifs_dbg(FYI, "%s: fullpath: %s\n", __func__, fullpath); cifs_dbg(FYI, "%s: fullpath: %s\n", __func__, fullpath);
mutex_lock(&dfs_cache.dc_lock); mutex_lock(&vol_lock);
vi = find_vol(fullpath); vi = find_vol(fullpath);
if (!IS_ERR(vi)) if (!IS_ERR(vi))
free_vol(vi); free_vol(vi);
mutex_unlock(&dfs_cache.dc_lock); mutex_unlock(&vol_lock);
} }
/* Get all tcons that are within a DFS namespace and can be refreshed */ /* Get all tcons that are within a DFS namespace and can be refreshed */
...@@ -1280,7 +1276,7 @@ static void get_tcons(struct TCP_Server_Info *server, struct list_head *head) ...@@ -1280,7 +1276,7 @@ static void get_tcons(struct TCP_Server_Info *server, struct list_head *head)
spin_unlock(&cifs_tcp_ses_lock); spin_unlock(&cifs_tcp_ses_lock);
} }
static inline bool is_dfs_link(const char *path) static bool is_dfs_link(const char *path)
{ {
char *s; char *s;
...@@ -1290,7 +1286,7 @@ static inline bool is_dfs_link(const char *path) ...@@ -1290,7 +1286,7 @@ static inline bool is_dfs_link(const char *path)
return !!strchr(s + 1, '\\'); return !!strchr(s + 1, '\\');
} }
static inline char *get_dfs_root(const char *path) static char *get_dfs_root(const char *path)
{ {
char *s, *npath; char *s, *npath;
...@@ -1310,8 +1306,9 @@ static inline char *get_dfs_root(const char *path) ...@@ -1310,8 +1306,9 @@ static inline char *get_dfs_root(const char *path)
} }
/* Find root SMB session out of a DFS link path */ /* Find root SMB session out of a DFS link path */
static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi, static struct cifs_ses *find_root_ses(struct vol_info *vi,
struct cifs_tcon *tcon, const char *path) struct cifs_tcon *tcon,
const char *path)
{ {
char *rpath; char *rpath;
int rc; int rc;
...@@ -1333,8 +1330,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi, ...@@ -1333,8 +1330,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi,
goto out; goto out;
} }
mdata = cifs_compose_mount_options(vi->vi_mntdata, rpath, &ref, mdata = cifs_compose_mount_options(vi->mntdata, rpath, &ref, &devname);
&devname);
free_dfs_info_param(&ref); free_dfs_info_param(&ref);
if (IS_ERR(mdata)) { if (IS_ERR(mdata)) {
...@@ -1373,14 +1369,13 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi, ...@@ -1373,14 +1369,13 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi,
} }
/* Refresh DFS cache entry from a given tcon */ /* Refresh DFS cache entry from a given tcon */
static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi, static void refresh_tcon(struct vol_info *vi, struct cifs_tcon *tcon)
struct cifs_tcon *tcon)
{ {
int rc = 0; int rc = 0;
unsigned int xid; unsigned int xid;
char *path, *npath; char *path, *npath;
unsigned int h; unsigned int h;
struct dfs_cache_entry *ce; struct cache_entry *ce;
struct dfs_info3_param *refs = NULL; struct dfs_info3_param *refs = NULL;
int numrefs = 0; int numrefs = 0;
struct cifs_ses *root_ses = NULL, *ses; struct cifs_ses *root_ses = NULL, *ses;
...@@ -1393,9 +1388,9 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi, ...@@ -1393,9 +1388,9 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi,
if (rc) if (rc)
goto out; goto out;
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = find_cache_entry(npath, &h); ce = lookup_cache_entry(npath, &h);
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
if (IS_ERR(ce)) { if (IS_ERR(ce)) {
rc = PTR_ERR(ce); rc = PTR_ERR(ce);
...@@ -1421,12 +1416,12 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi, ...@@ -1421,12 +1416,12 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi,
rc = -EOPNOTSUPP; rc = -EOPNOTSUPP;
} else { } else {
rc = ses->server->ops->get_dfs_refer(xid, ses, path, &refs, rc = ses->server->ops->get_dfs_refer(xid, ses, path, &refs,
&numrefs, dc->dc_nlsc, &numrefs, cache_nlsc,
tcon->remap); tcon->remap);
if (!rc) { if (!rc) {
mutex_lock(&dfs_cache_list_lock); mutex_lock(&list_lock);
ce = __update_cache_entry(npath, refs, numrefs); ce = __update_cache_entry(npath, refs, numrefs);
mutex_unlock(&dfs_cache_list_lock); mutex_unlock(&list_lock);
dump_refs(refs, numrefs); dump_refs(refs, numrefs);
free_dfs_info_array(refs, numrefs); free_dfs_info_array(refs, numrefs);
if (IS_ERR(ce)) if (IS_ERR(ce))
...@@ -1448,30 +1443,28 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi, ...@@ -1448,30 +1443,28 @@ static void do_refresh_tcon(struct dfs_cache *dc, struct dfs_cache_vol_info *vi,
*/ */
static void refresh_cache_worker(struct work_struct *work) static void refresh_cache_worker(struct work_struct *work)
{ {
struct dfs_cache *dc = container_of(work, struct dfs_cache, struct vol_info *vi;
dc_refresh.work);
struct dfs_cache_vol_info *vi;
struct TCP_Server_Info *server; struct TCP_Server_Info *server;
LIST_HEAD(list); LIST_HEAD(list);
struct cifs_tcon *tcon, *ntcon; struct cifs_tcon *tcon, *ntcon;
mutex_lock(&dc->dc_lock); mutex_lock(&vol_lock);
list_for_each_entry(vi, &dc->dc_vol_list, vi_list) { list_for_each_entry(vi, &vol_list, list) {
server = cifs_find_tcp_session(&vi->vi_vol); server = cifs_find_tcp_session(&vi->smb_vol);
if (IS_ERR_OR_NULL(server)) if (IS_ERR_OR_NULL(server))
continue; continue;
if (server->tcpStatus != CifsGood) if (server->tcpStatus != CifsGood)
goto next; goto next;
get_tcons(server, &list); get_tcons(server, &list);
list_for_each_entry_safe(tcon, ntcon, &list, ulist) { list_for_each_entry_safe(tcon, ntcon, &list, ulist) {
do_refresh_tcon(dc, vi, tcon); refresh_tcon(vi, tcon);
list_del_init(&tcon->ulist); list_del_init(&tcon->ulist);
cifs_put_tcon(tcon); cifs_put_tcon(tcon);
} }
next: next:
cifs_put_tcp_session(server, 0); cifs_put_tcp_session(server, 0);
} }
queue_delayed_work(cifsiod_wq, &dc->dc_refresh, dc->dc_ttl * HZ); queue_delayed_work(dfscache_wq, &refresh_task, cache_ttl * HZ);
mutex_unlock(&dc->dc_lock); mutex_unlock(&vol_lock);
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7