Commit 1a6d1c87 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

dmaengine: qcom: qcom_adm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230919133207.1400430-37-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent af9bc3c2
...@@ -904,7 +904,7 @@ static int adm_dma_probe(struct platform_device *pdev) ...@@ -904,7 +904,7 @@ static int adm_dma_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int adm_dma_remove(struct platform_device *pdev) static void adm_dma_remove(struct platform_device *pdev)
{ {
struct adm_device *adev = platform_get_drvdata(pdev); struct adm_device *adev = platform_get_drvdata(pdev);
struct adm_chan *achan; struct adm_chan *achan;
...@@ -927,8 +927,6 @@ static int adm_dma_remove(struct platform_device *pdev) ...@@ -927,8 +927,6 @@ static int adm_dma_remove(struct platform_device *pdev)
clk_disable_unprepare(adev->core_clk); clk_disable_unprepare(adev->core_clk);
clk_disable_unprepare(adev->iface_clk); clk_disable_unprepare(adev->iface_clk);
return 0;
} }
static const struct of_device_id adm_of_match[] = { static const struct of_device_id adm_of_match[] = {
...@@ -939,7 +937,7 @@ MODULE_DEVICE_TABLE(of, adm_of_match); ...@@ -939,7 +937,7 @@ MODULE_DEVICE_TABLE(of, adm_of_match);
static struct platform_driver adm_dma_driver = { static struct platform_driver adm_dma_driver = {
.probe = adm_dma_probe, .probe = adm_dma_probe,
.remove = adm_dma_remove, .remove_new = adm_dma_remove,
.driver = { .driver = {
.name = "adm-dma-engine", .name = "adm-dma-engine",
.of_match_table = adm_of_match, .of_match_table = adm_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment