Commit 1e42d384 authored by Paul Kocialkowski's avatar Paul Kocialkowski Committed by Mauro Carvalho Chehab

media: v4l2-ctrl: Add a comment on why we zero out compound controls fields

Since it's not necessarily very explicit why we need to zero some fields
in std_validate_compound, add a comment before the function to explain
why, which should help as a reminder.
Signed-off-by: default avatarPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 4b4d62b0
...@@ -1645,6 +1645,10 @@ static void std_log(const struct v4l2_ctrl *ctrl) ...@@ -1645,6 +1645,10 @@ static void std_log(const struct v4l2_ctrl *ctrl)
#define zero_padding(s) \ #define zero_padding(s) \
memset(&(s).padding, 0, sizeof((s).padding)) memset(&(s).padding, 0, sizeof((s).padding))
/*
* Compound controls validation requires setting unused fields/flags to zero
* in order to properly detect unchanged controls with std_equal's memcmp.
*/
static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx, static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx,
union v4l2_ctrl_ptr ptr) union v4l2_ctrl_ptr ptr)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment