Commit 1fd50a2c authored by Jernej Skrabec's avatar Jernej Skrabec Committed by Mauro Carvalho Chehab

media: cedrus: Use helpers to access capture queue

Accessing capture queue structue directly is not safe. Use helpers for
that.
Acked-by: default avatarPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 61ad1233
...@@ -197,12 +197,16 @@ static inline dma_addr_t cedrus_buf_addr(struct vb2_buffer *buf, ...@@ -197,12 +197,16 @@ static inline dma_addr_t cedrus_buf_addr(struct vb2_buffer *buf,
static inline dma_addr_t cedrus_dst_buf_addr(struct cedrus_ctx *ctx, static inline dma_addr_t cedrus_dst_buf_addr(struct cedrus_ctx *ctx,
int index, unsigned int plane) int index, unsigned int plane)
{ {
struct vb2_buffer *buf; struct vb2_buffer *buf = NULL;
struct vb2_queue *vq;
if (index < 0) if (index < 0)
return 0; return 0;
buf = ctx->fh.m2m_ctx->cap_q_ctx.q.bufs[index]; vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
if (vq)
buf = vb2_get_buffer(vq, index);
return buf ? cedrus_buf_addr(buf, &ctx->dst_fmt, plane) : 0; return buf ? cedrus_buf_addr(buf, &ctx->dst_fmt, plane) : 0;
} }
......
...@@ -97,7 +97,7 @@ static void cedrus_write_frame_list(struct cedrus_ctx *ctx, ...@@ -97,7 +97,7 @@ static void cedrus_write_frame_list(struct cedrus_ctx *ctx,
const struct v4l2_ctrl_h264_decode_params *decode = run->h264.decode_params; const struct v4l2_ctrl_h264_decode_params *decode = run->h264.decode_params;
const struct v4l2_ctrl_h264_slice_params *slice = run->h264.slice_params; const struct v4l2_ctrl_h264_slice_params *slice = run->h264.slice_params;
const struct v4l2_ctrl_h264_sps *sps = run->h264.sps; const struct v4l2_ctrl_h264_sps *sps = run->h264.sps;
struct vb2_queue *cap_q = &ctx->fh.m2m_ctx->cap_q_ctx.q; struct vb2_queue *cap_q;
struct cedrus_buffer *output_buf; struct cedrus_buffer *output_buf;
struct cedrus_dev *dev = ctx->dev; struct cedrus_dev *dev = ctx->dev;
unsigned long used_dpbs = 0; unsigned long used_dpbs = 0;
...@@ -105,6 +105,8 @@ static void cedrus_write_frame_list(struct cedrus_ctx *ctx, ...@@ -105,6 +105,8 @@ static void cedrus_write_frame_list(struct cedrus_ctx *ctx,
unsigned int output = 0; unsigned int output = 0;
unsigned int i; unsigned int i;
cap_q = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
memset(pic_list, 0, sizeof(pic_list)); memset(pic_list, 0, sizeof(pic_list));
for (i = 0; i < ARRAY_SIZE(decode->dpb); i++) { for (i = 0; i < ARRAY_SIZE(decode->dpb); i++) {
...@@ -168,12 +170,14 @@ static void _cedrus_write_ref_list(struct cedrus_ctx *ctx, ...@@ -168,12 +170,14 @@ static void _cedrus_write_ref_list(struct cedrus_ctx *ctx,
enum cedrus_h264_sram_off sram) enum cedrus_h264_sram_off sram)
{ {
const struct v4l2_ctrl_h264_decode_params *decode = run->h264.decode_params; const struct v4l2_ctrl_h264_decode_params *decode = run->h264.decode_params;
struct vb2_queue *cap_q = &ctx->fh.m2m_ctx->cap_q_ctx.q; struct vb2_queue *cap_q;
struct cedrus_dev *dev = ctx->dev; struct cedrus_dev *dev = ctx->dev;
u8 sram_array[CEDRUS_MAX_REF_IDX]; u8 sram_array[CEDRUS_MAX_REF_IDX];
unsigned int i; unsigned int i;
size_t size; size_t size;
cap_q = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
memset(sram_array, 0, sizeof(sram_array)); memset(sram_array, 0, sizeof(sram_array));
for (i = 0; i < num_ref; i++) { for (i = 0; i < num_ref; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment