Commit 204bddcb authored by Thierry Escande's avatar Thierry Escande Committed by Samuel Ortiz

NFC: nfcsim: Make use of the Digital layer

With this complete rewrite, the loopback nfcsim driver now relies on the
Digital layer of the nfc stack. As with the previous version, 2 nfc
devices are declared when the driver is initialized. The driver supports
the NFC_DEP protocol in NFC-A and NFC-F technologies.

The 2 devices are using a pair of virtual links for sk_buff exchange.
The out-link of one device is the in-link of the other and conversely.

To receive data, a device calls nfcsim_link_recv_skb() on its in-link
and waits for incoming data on a wait queue. To send data, a device
calls nfcsim_link_send_skb() on its out-link which stores the passed skb
and signals its wait queue. If the peer device was in the
nfcsim_link_recv_skb() call, it will be signaled and will be able to
pass the received sk_buff up to the Digital layer.
Signed-off-by: default avatarThierry Escande <thierry.escande@collabora.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 806bfe31
...@@ -18,523 +18,427 @@ ...@@ -18,523 +18,427 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/nfc.h> #include <linux/nfc.h>
#include <net/nfc/nfc.h> #include <net/nfc/nfc.h>
#include <net/nfc/digital.h>
#define DEV_ERR(_dev, fmt, args...) nfc_err(&_dev->nfc_dev->dev, \ #define NFCSIM_ERR(d, fmt, args...) nfc_err(&d->nfc_digital_dev->nfc_dev->dev, \
"%s: " fmt, __func__, ## args) "%s: " fmt, __func__, ## args)
#define DEV_DBG(_dev, fmt, args...) dev_dbg(&_dev->nfc_dev->dev, \ #define NFCSIM_DBG(d, fmt, args...) dev_dbg(&d->nfc_digital_dev->nfc_dev->dev, \
"%s: " fmt, __func__, ## args) "%s: " fmt, __func__, ## args)
#define NFCSIM_VERSION "0.1" #define NFCSIM_VERSION "0.2"
#define NFCSIM_POLL_NONE 0 #define NFCSIM_MODE_NONE 0
#define NFCSIM_POLL_INITIATOR 1 #define NFCSIM_MODE_INITIATOR 1
#define NFCSIM_POLL_TARGET 2 #define NFCSIM_MODE_TARGET 2
#define NFCSIM_POLL_DUAL (NFCSIM_POLL_INITIATOR | NFCSIM_POLL_TARGET)
#define RX_DEFAULT_DELAY 5 #define NFCSIM_CAPABILITIES (NFC_DIGITAL_DRV_CAPS_IN_CRC | \
NFC_DIGITAL_DRV_CAPS_TG_CRC)
struct nfcsim { struct nfcsim {
struct nfc_dev *nfc_dev; struct nfc_digital_dev *nfc_digital_dev;
struct mutex lock; struct work_struct recv_work;
struct delayed_work send_work;
struct delayed_work recv_work;
struct sk_buff *clone_skb; struct nfcsim_link *link_in;
struct nfcsim_link *link_out;
struct delayed_work poll_work; bool up;
u8 polling_mode; u8 mode;
u8 curr_polling_mode; u8 rf_tech;
u8 shutting_down; u16 recv_timeout;
u8 up; nfc_digital_cmd_complete_t cb;
void *arg;
};
u8 initiator; struct nfcsim_link {
struct mutex lock;
u32 rx_delay; u8 rf_tech;
u8 mode;
data_exchange_cb_t cb; u8 shutdown;
void *cb_context;
struct nfcsim *peer_dev; struct sk_buff *skb;
wait_queue_head_t recv_wait;
u8 cond;
}; };
static struct nfcsim *dev0; static struct nfcsim_link *nfcsim_link_new(void)
static struct nfcsim *dev1;
static struct workqueue_struct *wq;
static void nfcsim_cleanup_dev(struct nfcsim *dev, u8 shutdown)
{ {
DEV_DBG(dev, "shutdown=%d\n", shutdown); struct nfcsim_link *link;
mutex_lock(&dev->lock); link = kzalloc(sizeof(struct nfcsim_link), GFP_KERNEL);
if (!link)
return NULL;
dev->polling_mode = NFCSIM_POLL_NONE; mutex_init(&link->lock);
dev->shutting_down = shutdown; init_waitqueue_head(&link->recv_wait);
dev->cb = NULL;
dev_kfree_skb(dev->clone_skb);
dev->clone_skb = NULL;
mutex_unlock(&dev->lock); return link;
cancel_delayed_work_sync(&dev->poll_work);
cancel_delayed_work_sync(&dev->recv_work);
} }
static int nfcsim_target_found(struct nfcsim *dev) static void nfcsim_link_free(struct nfcsim_link *link)
{ {
struct nfc_target nfc_tgt; dev_kfree_skb(link->skb);
kfree(link);
}
DEV_DBG(dev, "\n"); static void nfcsim_link_recv_wake(struct nfcsim_link *link)
{
link->cond = 1;
wake_up_interruptible(&link->recv_wait);
}
memset(&nfc_tgt, 0, sizeof(struct nfc_target)); static void nfcsim_link_set_skb(struct nfcsim_link *link, struct sk_buff *skb,
u8 rf_tech, u8 mode)
{
mutex_lock(&link->lock);
nfc_tgt.supported_protocols = NFC_PROTO_NFC_DEP_MASK; dev_kfree_skb(link->skb);
nfc_targets_found(dev->nfc_dev, &nfc_tgt, 1); link->skb = skb;
link->rf_tech = rf_tech;
link->mode = mode;
return 0; mutex_unlock(&link->lock);
} }
static int nfcsim_dev_up(struct nfc_dev *nfc_dev) static void nfcsim_link_recv_cancel(struct nfcsim_link *link)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); mutex_lock(&link->lock);
DEV_DBG(dev, "\n");
mutex_lock(&dev->lock); link->mode = NFCSIM_MODE_NONE;
dev->up = 1; mutex_unlock(&link->lock);
mutex_unlock(&dev->lock); nfcsim_link_recv_wake(link);
return 0;
} }
static int nfcsim_dev_down(struct nfc_dev *nfc_dev) static void nfcsim_link_shutdown(struct nfcsim_link *link)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); mutex_lock(&link->lock);
DEV_DBG(dev, "\n");
mutex_lock(&dev->lock);
dev->up = 0; link->shutdown = 1;
link->mode = NFCSIM_MODE_NONE;
mutex_unlock(&dev->lock); mutex_unlock(&link->lock);
return 0; nfcsim_link_recv_wake(link);
} }
static int nfcsim_dep_link_up(struct nfc_dev *nfc_dev, static struct sk_buff *nfcsim_link_recv_skb(struct nfcsim_link *link,
struct nfc_target *target, int timeout, u8 rf_tech, u8 mode)
u8 comm_mode, u8 *gb, size_t gb_len)
{ {
int rc; int rc;
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct sk_buff *skb;
struct nfcsim *peer = dev->peer_dev;
u8 *remote_gb;
size_t remote_gb_len;
DEV_DBG(dev, "target_idx: %d, comm_mode: %d\n", target->idx, comm_mode); rc = wait_event_interruptible_timeout(link->recv_wait,
link->cond,
msecs_to_jiffies(timeout));
mutex_lock(&peer->lock); mutex_lock(&link->lock);
nfc_tm_activated(peer->nfc_dev, NFC_PROTO_NFC_DEP_MASK, skb = link->skb;
NFC_COMM_ACTIVE, gb, gb_len); link->skb = NULL;
remote_gb = nfc_get_local_general_bytes(peer->nfc_dev, &remote_gb_len); if (!rc) {
if (!remote_gb) { rc = -ETIMEDOUT;
DEV_ERR(peer, "Can't get remote general bytes\n"); goto done;
}
mutex_unlock(&peer->lock); if (!skb || link->rf_tech != rf_tech || link->mode == mode) {
return -EINVAL; rc = -EINVAL;
goto done;
} }
mutex_unlock(&peer->lock); if (link->shutdown) {
rc = -ENODEV;
goto done;
}
mutex_lock(&dev->lock); done:
mutex_unlock(&link->lock);
rc = nfc_set_remote_general_bytes(nfc_dev, remote_gb, remote_gb_len); if (rc < 0) {
if (rc) { dev_kfree_skb(skb);
DEV_ERR(dev, "Can't set remote general bytes\n"); skb = ERR_PTR(rc);
mutex_unlock(&dev->lock);
return rc;
} }
rc = nfc_dep_link_is_up(nfc_dev, target->idx, NFC_COMM_ACTIVE, link->cond = 0;
NFC_RF_INITIATOR);
mutex_unlock(&dev->lock); return skb;
return rc;
} }
static int nfcsim_dep_link_down(struct nfc_dev *nfc_dev) static void nfcsim_send_wq(struct work_struct *work)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct nfcsim *dev = container_of(work, struct nfcsim, send_work.work);
DEV_DBG(dev, "\n");
nfcsim_cleanup_dev(dev, 0); /*
* To effectively send data, the device just wake up its link_out which
return 0; * is the link_in of the peer device. The exchanged skb has already been
* stored in the dev->link_out through nfcsim_link_set_skb().
*/
nfcsim_link_recv_wake(dev->link_out);
} }
static int nfcsim_start_poll(struct nfc_dev *nfc_dev, static void nfcsim_recv_wq(struct work_struct *work)
u32 im_protocols, u32 tm_protocols)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct nfcsim *dev = container_of(work, struct nfcsim, recv_work);
int rc; struct sk_buff *skb;
mutex_lock(&dev->lock); skb = nfcsim_link_recv_skb(dev->link_in, dev->recv_timeout,
dev->rf_tech, dev->mode);
if (dev->polling_mode != NFCSIM_POLL_NONE) { if (!dev->up) {
DEV_ERR(dev, "Already in polling mode\n"); NFCSIM_ERR(dev, "Device is down\n");
rc = -EBUSY;
goto exit;
}
if (im_protocols & NFC_PROTO_NFC_DEP_MASK)
dev->polling_mode |= NFCSIM_POLL_INITIATOR;
if (tm_protocols & NFC_PROTO_NFC_DEP_MASK) if (!IS_ERR(skb))
dev->polling_mode |= NFCSIM_POLL_TARGET; dev_kfree_skb(skb);
if (dev->polling_mode == NFCSIM_POLL_NONE) { skb = ERR_PTR(-ENODEV);
DEV_ERR(dev, "Unsupported polling mode\n");
rc = -EINVAL;
goto exit;
} }
dev->initiator = 0; dev->cb(dev->nfc_digital_dev, dev->arg, skb);
dev->curr_polling_mode = NFCSIM_POLL_NONE;
queue_delayed_work(wq, &dev->poll_work, 0);
DEV_DBG(dev, "Start polling: im: 0x%X, tm: 0x%X\n", im_protocols,
tm_protocols);
rc = 0;
exit:
mutex_unlock(&dev->lock);
return rc;
} }
static void nfcsim_stop_poll(struct nfc_dev *nfc_dev) static int nfcsim_send(struct nfc_digital_dev *ddev, struct sk_buff *skb,
u16 timeout, nfc_digital_cmd_complete_t cb, void *arg)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct nfcsim *dev = nfc_digital_get_drvdata(ddev);
u8 delay;
DEV_DBG(dev, "Stop poll\n");
mutex_lock(&dev->lock); if (!dev->up) {
NFCSIM_ERR(dev, "Device is down\n");
return -ENODEV;
}
dev->polling_mode = NFCSIM_POLL_NONE; dev->recv_timeout = timeout;
dev->cb = cb;
dev->arg = arg;
mutex_unlock(&dev->lock); schedule_work(&dev->recv_work);
cancel_delayed_work_sync(&dev->poll_work); if (skb) {
} nfcsim_link_set_skb(dev->link_out, skb, dev->rf_tech,
dev->mode);
static int nfcsim_activate_target(struct nfc_dev *nfc_dev, /* Add random delay (between 3 and 10 ms) before sending data */
struct nfc_target *target, u32 protocol) get_random_bytes(&delay, 1);
{ delay = 3 + (delay & 0x07);
struct nfcsim *dev = nfc_get_drvdata(nfc_dev);
DEV_DBG(dev, "\n"); schedule_delayed_work(&dev->send_work, msecs_to_jiffies(delay));
}
return -ENOTSUPP; return 0;
} }
static void nfcsim_deactivate_target(struct nfc_dev *nfc_dev, static void nfcsim_abort_cmd(struct nfc_digital_dev *ddev)
struct nfc_target *target, u8 mode)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct nfcsim *dev = nfc_digital_get_drvdata(ddev);
DEV_DBG(dev, "\n"); nfcsim_link_recv_cancel(dev->link_in);
} }
static void nfcsim_wq_recv(struct work_struct *work) static int nfcsim_switch_rf(struct nfc_digital_dev *ddev, bool on)
{ {
struct nfcsim *dev = container_of(work, struct nfcsim, struct nfcsim *dev = nfc_digital_get_drvdata(ddev);
recv_work.work);
mutex_lock(&dev->lock);
if (dev->shutting_down || !dev->up || !dev->clone_skb) {
dev_kfree_skb(dev->clone_skb);
goto exit;
}
if (dev->initiator) {
if (!dev->cb) {
DEV_ERR(dev, "Null recv callback\n");
dev_kfree_skb(dev->clone_skb);
goto exit;
}
dev->cb(dev->cb_context, dev->clone_skb, 0); dev->up = on;
dev->cb = NULL;
} else {
nfc_tm_data_received(dev->nfc_dev, dev->clone_skb);
}
exit: return 0;
dev->clone_skb = NULL;
mutex_unlock(&dev->lock);
} }
static int nfcsim_tx(struct nfc_dev *nfc_dev, struct nfc_target *target, static int nfcsim_in_configure_hw(struct nfc_digital_dev *ddev,
struct sk_buff *skb, data_exchange_cb_t cb, int type, int param)
void *cb_context)
{ {
struct nfcsim *dev = nfc_get_drvdata(nfc_dev); struct nfcsim *dev = nfc_digital_get_drvdata(ddev);
struct nfcsim *peer = dev->peer_dev;
int err;
mutex_lock(&dev->lock); switch (type) {
case NFC_DIGITAL_CONFIG_RF_TECH:
dev->up = true;
dev->mode = NFCSIM_MODE_INITIATOR;
dev->rf_tech = param;
break;
if (dev->shutting_down || !dev->up) { case NFC_DIGITAL_CONFIG_FRAMING:
mutex_unlock(&dev->lock); break;
err = -ENODEV;
goto exit;
}
dev->cb = cb; default:
dev->cb_context = cb_context; NFCSIM_ERR(dev, "Invalid configuration type: %d\n", type);
return -EINVAL;
mutex_unlock(&dev->lock);
mutex_lock(&peer->lock);
peer->clone_skb = skb_clone(skb, GFP_KERNEL);
if (!peer->clone_skb) {
DEV_ERR(dev, "skb_clone failed\n");
mutex_unlock(&peer->lock);
err = -ENOMEM;
goto exit;
} }
/* This simulates an arbitrary transmission delay between the 2 devices. return 0;
* If packet transmission occurs immediately between them, we have a
* non-stop flow of several tens of thousands SYMM packets per second
* and a burning cpu.
*/
queue_delayed_work(wq, &peer->recv_work,
msecs_to_jiffies(dev->rx_delay));
mutex_unlock(&peer->lock);
err = 0;
exit:
dev_kfree_skb(skb);
return err;
} }
static int nfcsim_im_transceive(struct nfc_dev *nfc_dev, static int nfcsim_in_send_cmd(struct nfc_digital_dev *ddev,
struct nfc_target *target, struct sk_buff *skb, struct sk_buff *skb, u16 timeout,
data_exchange_cb_t cb, void *cb_context) nfc_digital_cmd_complete_t cb, void *arg)
{ {
return nfcsim_tx(nfc_dev, target, skb, cb, cb_context); return nfcsim_send(ddev, skb, timeout, cb, arg);
} }
static int nfcsim_tm_send(struct nfc_dev *nfc_dev, struct sk_buff *skb) static int nfcsim_tg_configure_hw(struct nfc_digital_dev *ddev,
int type, int param)
{ {
return nfcsim_tx(nfc_dev, NULL, skb, NULL, NULL); struct nfcsim *dev = nfc_digital_get_drvdata(ddev);
}
static struct nfc_ops nfcsim_nfc_ops = { switch (type) {
.dev_up = nfcsim_dev_up, case NFC_DIGITAL_CONFIG_RF_TECH:
.dev_down = nfcsim_dev_down, dev->up = true;
.dep_link_up = nfcsim_dep_link_up, dev->mode = NFCSIM_MODE_TARGET;
.dep_link_down = nfcsim_dep_link_down, dev->rf_tech = param;
.start_poll = nfcsim_start_poll, break;
.stop_poll = nfcsim_stop_poll,
.activate_target = nfcsim_activate_target,
.deactivate_target = nfcsim_deactivate_target,
.im_transceive = nfcsim_im_transceive,
.tm_send = nfcsim_tm_send,
};
static void nfcsim_set_polling_mode(struct nfcsim *dev) case NFC_DIGITAL_CONFIG_FRAMING:
{ break;
if (dev->polling_mode == NFCSIM_POLL_NONE) {
dev->curr_polling_mode = NFCSIM_POLL_NONE;
return;
}
if (dev->curr_polling_mode == NFCSIM_POLL_NONE) {
if (dev->polling_mode & NFCSIM_POLL_INITIATOR)
dev->curr_polling_mode = NFCSIM_POLL_INITIATOR;
else
dev->curr_polling_mode = NFCSIM_POLL_TARGET;
return; default:
NFCSIM_ERR(dev, "Invalid configuration type: %d\n", type);
return -EINVAL;
} }
if (dev->polling_mode == NFCSIM_POLL_DUAL) { return 0;
if (dev->curr_polling_mode == NFCSIM_POLL_TARGET)
dev->curr_polling_mode = NFCSIM_POLL_INITIATOR;
else
dev->curr_polling_mode = NFCSIM_POLL_TARGET;
}
} }
static void nfcsim_wq_poll(struct work_struct *work) static int nfcsim_tg_send_cmd(struct nfc_digital_dev *ddev,
struct sk_buff *skb, u16 timeout,
nfc_digital_cmd_complete_t cb, void *arg)
{ {
struct nfcsim *dev = container_of(work, struct nfcsim, poll_work.work); return nfcsim_send(ddev, skb, timeout, cb, arg);
struct nfcsim *peer = dev->peer_dev; }
/* These work items run on an ordered workqueue and are therefore
* serialized. So we can take both mutexes without being dead locked.
*/
mutex_lock(&dev->lock);
mutex_lock(&peer->lock);
nfcsim_set_polling_mode(dev);
if (dev->curr_polling_mode == NFCSIM_POLL_NONE) {
DEV_DBG(dev, "Not polling\n");
goto unlock;
}
DEV_DBG(dev, "Polling as %s",
dev->curr_polling_mode == NFCSIM_POLL_INITIATOR ?
"initiator\n" : "target\n");
if (dev->curr_polling_mode == NFCSIM_POLL_TARGET)
goto sched_work;
if (peer->curr_polling_mode == NFCSIM_POLL_TARGET) {
peer->polling_mode = NFCSIM_POLL_NONE;
dev->polling_mode = NFCSIM_POLL_NONE;
dev->initiator = 1;
nfcsim_target_found(dev); static int nfcsim_tg_listen(struct nfc_digital_dev *ddev, u16 timeout,
nfc_digital_cmd_complete_t cb, void *arg)
{
return nfcsim_send(ddev, NULL, timeout, cb, arg);
}
goto unlock; static struct nfc_digital_ops nfcsim_digital_ops = {
} .in_configure_hw = nfcsim_in_configure_hw,
.in_send_cmd = nfcsim_in_send_cmd,
sched_work: .tg_listen = nfcsim_tg_listen,
/* This defines the delay for an initiator to check if the other device .tg_configure_hw = nfcsim_tg_configure_hw,
* is polling in target mode. .tg_send_cmd = nfcsim_tg_send_cmd,
* If the device starts in dual mode polling, it switches between
* initiator and target at every round.
* Because the wq is ordered and only 1 work item is executed at a time,
* we'll always have one device polling as initiator and the other as
* target at some point, even if both are started in dual mode.
*/
queue_delayed_work(wq, &dev->poll_work, msecs_to_jiffies(200));
unlock: .abort_cmd = nfcsim_abort_cmd,
mutex_unlock(&peer->lock); .switch_rf = nfcsim_switch_rf,
mutex_unlock(&dev->lock); };
}
static struct nfcsim *nfcsim_init_dev(void) static struct nfcsim *nfcsim_device_new(struct nfcsim_link *link_in,
struct nfcsim_link *link_out)
{ {
struct nfcsim *dev; struct nfcsim *dev;
int rc = -ENOMEM; int rc;
dev = kzalloc(sizeof(*dev), GFP_KERNEL); dev = kzalloc(sizeof(struct nfcsim), GFP_KERNEL);
if (dev == NULL) if (!dev)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
mutex_init(&dev->lock); INIT_DELAYED_WORK(&dev->send_work, nfcsim_send_wq);
INIT_WORK(&dev->recv_work, nfcsim_recv_wq);
INIT_DELAYED_WORK(&dev->recv_work, nfcsim_wq_recv); dev->nfc_digital_dev =
INIT_DELAYED_WORK(&dev->poll_work, nfcsim_wq_poll); nfc_digital_allocate_device(&nfcsim_digital_ops,
dev->nfc_dev = nfc_allocate_device(&nfcsim_nfc_ops,
NFC_PROTO_NFC_DEP_MASK, NFC_PROTO_NFC_DEP_MASK,
NFCSIM_CAPABILITIES,
0, 0); 0, 0);
if (!dev->nfc_dev) if (!dev->nfc_digital_dev) {
goto error; kfree(dev);
return ERR_PTR(-ENOMEM);
nfc_set_drvdata(dev->nfc_dev, dev); }
rc = nfc_register_device(dev->nfc_dev);
if (rc)
goto free_nfc_dev;
dev->rx_delay = RX_DEFAULT_DELAY; nfc_digital_set_drvdata(dev->nfc_digital_dev, dev);
return dev;
free_nfc_dev: dev->link_in = link_in;
nfc_free_device(dev->nfc_dev); dev->link_out = link_out;
error: rc = nfc_digital_register_device(dev->nfc_digital_dev);
if (rc) {
pr_err("Could not register digital device (%d)\n", rc);
nfc_digital_free_device(dev->nfc_digital_dev);
kfree(dev); kfree(dev);
return ERR_PTR(rc); return ERR_PTR(rc);
}
return dev;
} }
static void nfcsim_free_device(struct nfcsim *dev) static void nfcsim_device_free(struct nfcsim *dev)
{ {
nfc_unregister_device(dev->nfc_dev); nfc_digital_unregister_device(dev->nfc_digital_dev);
dev->up = false;
nfcsim_link_shutdown(dev->link_in);
cancel_delayed_work_sync(&dev->send_work);
cancel_work_sync(&dev->recv_work);
nfc_free_device(dev->nfc_dev); nfc_digital_free_device(dev->nfc_digital_dev);
kfree(dev); kfree(dev);
} }
static struct nfcsim *dev0;
static struct nfcsim *dev1;
static int __init nfcsim_init(void) static int __init nfcsim_init(void)
{ {
struct nfcsim_link *link0, *link1;
int rc; int rc;
/* We need an ordered wq to ensure that poll_work items are executed link0 = nfcsim_link_new();
* one at a time. link1 = nfcsim_link_new();
*/ if (!link0 || !link1) {
wq = alloc_ordered_workqueue("nfcsim", 0);
if (!wq) {
rc = -ENOMEM; rc = -ENOMEM;
goto exit; goto exit_err;
} }
dev0 = nfcsim_init_dev(); dev0 = nfcsim_device_new(link0, link1);
if (IS_ERR(dev0)) { if (IS_ERR(dev0)) {
rc = PTR_ERR(dev0); rc = PTR_ERR(dev0);
goto exit; goto exit_err;
} }
dev1 = nfcsim_init_dev(); dev1 = nfcsim_device_new(link1, link0);
if (IS_ERR(dev1)) { if (IS_ERR(dev1)) {
kfree(dev0); nfcsim_device_free(dev0);
rc = PTR_ERR(dev1); rc = PTR_ERR(dev1);
goto exit; goto exit_err;
} }
dev0->peer_dev = dev1; pr_info("nfcsim " NFCSIM_VERSION " initialized\n");
dev1->peer_dev = dev0;
pr_debug("NFCsim " NFCSIM_VERSION " initialized\n"); return 0;
exit_err:
pr_err("Failed to initialize nfcsim driver (%d)\n", rc);
rc = 0; nfcsim_link_free(link0);
exit: nfcsim_link_free(link1);
if (rc)
pr_err("Failed to initialize nfcsim driver (%d)\n",
rc);
return rc; return rc;
} }
static void __exit nfcsim_exit(void) static void __exit nfcsim_exit(void)
{ {
nfcsim_cleanup_dev(dev0, 1); struct nfcsim_link *link0, *link1;
nfcsim_cleanup_dev(dev1, 1);
link0 = dev0->link_in;
link1 = dev0->link_out;
nfcsim_free_device(dev0); nfcsim_device_free(dev0);
nfcsim_free_device(dev1); nfcsim_device_free(dev1);
destroy_workqueue(wq); nfcsim_link_free(link0);
nfcsim_link_free(link1);
} }
module_init(nfcsim_init); module_init(nfcsim_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment