Commit 20ee451f authored by Joe Perches's avatar Joe Perches Committed by Mimi Zohar

security: integrity: Use a more current logging style

Convert printks to pr_<level>.
Add pr_fmt.
Remove embedded prefixes.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarMimi Zohar <zohar@linux.vnet.ibm.com>
parent 74dd744f
...@@ -13,6 +13,8 @@ ...@@ -13,6 +13,8 @@
* Using root's kernel master key (kmk), calculate the HMAC * Using root's kernel master key (kmk), calculate the HMAC
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/module.h> #include <linux/module.h>
#include <linux/crypto.h> #include <linux/crypto.h>
#include <linux/xattr.h> #include <linux/xattr.h>
...@@ -221,7 +223,7 @@ int evm_init_hmac(struct inode *inode, const struct xattr *lsm_xattr, ...@@ -221,7 +223,7 @@ int evm_init_hmac(struct inode *inode, const struct xattr *lsm_xattr,
desc = init_desc(EVM_XATTR_HMAC); desc = init_desc(EVM_XATTR_HMAC);
if (IS_ERR(desc)) { if (IS_ERR(desc)) {
printk(KERN_INFO "init_desc failed\n"); pr_info("init_desc failed\n");
return PTR_ERR(desc); return PTR_ERR(desc);
} }
......
...@@ -14,6 +14,8 @@ ...@@ -14,6 +14,8 @@
* evm_inode_removexattr, and evm_verifyxattr * evm_inode_removexattr, and evm_verifyxattr
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/module.h> #include <linux/module.h>
#include <linux/crypto.h> #include <linux/crypto.h>
#include <linux/audit.h> #include <linux/audit.h>
...@@ -432,7 +434,7 @@ static int __init init_evm(void) ...@@ -432,7 +434,7 @@ static int __init init_evm(void)
error = evm_init_secfs(); error = evm_init_secfs();
if (error < 0) { if (error < 0) {
printk(KERN_INFO "EVM: Error registering secfs\n"); pr_info("Error registering secfs\n");
goto err; goto err;
} }
...@@ -449,7 +451,7 @@ static int __init evm_display_config(void) ...@@ -449,7 +451,7 @@ static int __init evm_display_config(void)
char **xattrname; char **xattrname;
for (xattrname = evm_config_xattrnames; *xattrname != NULL; xattrname++) for (xattrname = evm_config_xattrnames; *xattrname != NULL; xattrname++)
printk(KERN_INFO "EVM: %s\n", *xattrname); pr_info("%s\n", *xattrname);
return 0; return 0;
} }
......
...@@ -13,6 +13,8 @@ ...@@ -13,6 +13,8 @@
* - Get the key and enable EVM * - Get the key and enable EVM
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/uaccess.h> #include <linux/uaccess.h>
#include <linux/module.h> #include <linux/module.h>
#include "evm.h" #include "evm.h"
...@@ -79,9 +81,9 @@ static ssize_t evm_write_key(struct file *file, const char __user *buf, ...@@ -79,9 +81,9 @@ static ssize_t evm_write_key(struct file *file, const char __user *buf,
error = evm_init_key(); error = evm_init_key();
if (!error) { if (!error) {
evm_initialized = 1; evm_initialized = 1;
pr_info("EVM: initialized\n"); pr_info("initialized\n");
} else } else
pr_err("EVM: initialization failed\n"); pr_err("initialization failed\n");
return count; return count;
} }
......
...@@ -13,6 +13,8 @@ ...@@ -13,6 +13,8 @@
* Calculates md5/sha1 file hash, template hash, boot-aggreate hash * Calculates md5/sha1 file hash, template hash, boot-aggreate hash
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/file.h> #include <linux/file.h>
#include <linux/crypto.h> #include <linux/crypto.h>
...@@ -212,7 +214,7 @@ static void __init ima_pcrread(int idx, u8 *pcr) ...@@ -212,7 +214,7 @@ static void __init ima_pcrread(int idx, u8 *pcr)
return; return;
if (tpm_pcr_read(TPM_ANY_NUM, idx, pcr) != 0) if (tpm_pcr_read(TPM_ANY_NUM, idx, pcr) != 0)
pr_err("IMA: Error Communicating to TPM chip\n"); pr_err("Error Communicating to TPM chip\n");
} }
/* /*
......
...@@ -14,6 +14,9 @@ ...@@ -14,6 +14,9 @@
* File: ima_init.c * File: ima_init.c
* initialization and cleanup functions * initialization and cleanup functions
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/module.h> #include <linux/module.h>
#include <linux/scatterlist.h> #include <linux/scatterlist.h>
#include <linux/slab.h> #include <linux/slab.h>
...@@ -93,7 +96,7 @@ int __init ima_init(void) ...@@ -93,7 +96,7 @@ int __init ima_init(void)
ima_used_chip = 1; ima_used_chip = 1;
if (!ima_used_chip) if (!ima_used_chip)
pr_info("IMA: No TPM chip found, activating TPM-bypass!\n"); pr_info("No TPM chip found, activating TPM-bypass!\n");
rc = ima_init_crypto(); rc = ima_init_crypto();
if (rc) if (rc)
......
...@@ -18,6 +18,9 @@ ...@@ -18,6 +18,9 @@
* The measurement list is append-only. No entry is * The measurement list is append-only. No entry is
* ever removed or changed during the boot-cycle. * ever removed or changed during the boot-cycle.
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/module.h> #include <linux/module.h>
#include <linux/rculist.h> #include <linux/rculist.h>
#include <linux/slab.h> #include <linux/slab.h>
...@@ -72,7 +75,7 @@ static int ima_add_digest_entry(struct ima_template_entry *entry) ...@@ -72,7 +75,7 @@ static int ima_add_digest_entry(struct ima_template_entry *entry)
qe = kmalloc(sizeof(*qe), GFP_KERNEL); qe = kmalloc(sizeof(*qe), GFP_KERNEL);
if (qe == NULL) { if (qe == NULL) {
pr_err("IMA: OUT OF MEMORY ERROR creating queue entry.\n"); pr_err("OUT OF MEMORY ERROR creating queue entry\n");
return -ENOMEM; return -ENOMEM;
} }
qe->entry = entry; qe->entry = entry;
...@@ -95,8 +98,7 @@ static int ima_pcr_extend(const u8 *hash) ...@@ -95,8 +98,7 @@ static int ima_pcr_extend(const u8 *hash)
result = tpm_pcr_extend(TPM_ANY_NUM, CONFIG_IMA_MEASURE_PCR_IDX, hash); result = tpm_pcr_extend(TPM_ANY_NUM, CONFIG_IMA_MEASURE_PCR_IDX, hash);
if (result != 0) if (result != 0)
pr_err("IMA: Error Communicating to TPM chip, result: %d\n", pr_err("Error Communicating to TPM chip, result: %d\n", result);
result);
return result; return result;
} }
......
...@@ -12,6 +12,9 @@ ...@@ -12,6 +12,9 @@
* File: ima_template.c * File: ima_template.c
* Helpers to manage template descriptors. * Helpers to manage template descriptors.
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <crypto/hash_info.h> #include <crypto/hash_info.h>
#include "ima.h" #include "ima.h"
...@@ -58,7 +61,7 @@ static int __init ima_template_setup(char *str) ...@@ -58,7 +61,7 @@ static int __init ima_template_setup(char *str)
*/ */
if (template_len == 3 && strcmp(str, IMA_TEMPLATE_IMA_NAME) == 0 && if (template_len == 3 && strcmp(str, IMA_TEMPLATE_IMA_NAME) == 0 &&
ima_hash_algo != HASH_ALGO_SHA1 && ima_hash_algo != HASH_ALGO_MD5) { ima_hash_algo != HASH_ALGO_SHA1 && ima_hash_algo != HASH_ALGO_MD5) {
pr_err("IMA: template does not support hash alg\n"); pr_err("template does not support hash alg\n");
return 1; return 1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment