Commit 217b870e authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman

greybus: get rid of a weird idiom

It strikes me as strange to add one to a value while checking to see
if it exceeds a maximum.
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent 380f6bdd
......@@ -282,7 +282,7 @@ static int create_string(struct greybus_module *gmod,
int string_size;
struct gmod_string *gmod_string;
if ((gmod->num_strings + 1) >= MAX_STRINGS_PER_MODULE) {
if (gmod->num_strings == MAX_STRINGS_PER_MODULE) {
dev_err(gmod->dev.parent,
"too many strings for this module!\n");
return -EINVAL;
......@@ -315,7 +315,7 @@ static int create_cport(struct greybus_module *gmod,
{
struct gmod_cport *gmod_cport;
if ((gmod->num_cports + 1) >= MAX_CPORTS_PER_MODULE) {
if (gmod->num_cports == MAX_CPORTS_PER_MODULE) {
dev_err(gmod->dev.parent, "too many cports for this module!\n");
return -EINVAL;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment