Commit 219cf43c authored by Jinlong Chen's avatar Jinlong Chen Committed by Jens Axboe

blk-mq: move queue_is_mq out of blk_mq_cancel_work_sync

The only caller that needs queue_is_mq check is del_gendisk, so move the
check into it.
Signed-off-by: default avatarJinlong Chen <nickyc975@zju.edu.cn>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20221030094730.1275463-1-nickyc975@zju.edu.cnSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent adff2158
...@@ -4883,7 +4883,6 @@ EXPORT_SYMBOL(blk_mq_rq_cpu); ...@@ -4883,7 +4883,6 @@ EXPORT_SYMBOL(blk_mq_rq_cpu);
void blk_mq_cancel_work_sync(struct request_queue *q) void blk_mq_cancel_work_sync(struct request_queue *q)
{ {
if (queue_is_mq(q)) {
struct blk_mq_hw_ctx *hctx; struct blk_mq_hw_ctx *hctx;
unsigned long i; unsigned long i;
...@@ -4891,7 +4890,6 @@ void blk_mq_cancel_work_sync(struct request_queue *q) ...@@ -4891,7 +4890,6 @@ void blk_mq_cancel_work_sync(struct request_queue *q)
queue_for_each_hw_ctx(q, hctx, i) queue_for_each_hw_ctx(q, hctx, i)
cancel_delayed_work_sync(&hctx->run_work); cancel_delayed_work_sync(&hctx->run_work);
}
} }
static int __init blk_mq_init(void) static int __init blk_mq_init(void)
......
...@@ -638,6 +638,8 @@ void del_gendisk(struct gendisk *disk) ...@@ -638,6 +638,8 @@ void del_gendisk(struct gendisk *disk)
blk_sync_queue(q); blk_sync_queue(q);
blk_flush_integrity(); blk_flush_integrity();
if (queue_is_mq(q))
blk_mq_cancel_work_sync(q); blk_mq_cancel_work_sync(q);
blk_mq_quiesce_queue(q); blk_mq_quiesce_queue(q);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment