Commit 2203718c authored by Georgi Valkov's avatar Georgi Valkov Committed by David S. Miller

usbnet: ipheth: fix risk of NULL pointer deallocation

The cleanup precedure in ipheth_probe will attempt to free a
NULL pointer in dev->ctrl_buf if the memory allocation for
this buffer is not successful. While kfree ignores NULL pointers,
and the existing code is safe, it is a better design to rearrange
the goto labels and avoid this.
Signed-off-by: default avatarGeorgi Valkov <gvalkov@gmail.com>
Signed-off-by: default avatarFoster Snowhill <forst@pen.gy>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd5f4d7d
...@@ -510,8 +510,8 @@ static int ipheth_probe(struct usb_interface *intf, ...@@ -510,8 +510,8 @@ static int ipheth_probe(struct usb_interface *intf,
ipheth_free_urbs(dev); ipheth_free_urbs(dev);
err_alloc_urbs: err_alloc_urbs:
err_get_macaddr: err_get_macaddr:
err_alloc_ctrl_buf:
kfree(dev->ctrl_buf); kfree(dev->ctrl_buf);
err_alloc_ctrl_buf:
err_endpoints: err_endpoints:
free_netdev(netdev); free_netdev(netdev);
return retval; return retval;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment