Commit 22d11424 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Staging: comedi: clean up sparse issues in proc.c

The whole file should be converted to use seqfile, if it's even
still needed.  Or move to debugfs.

Anyway, I fixed up the minor issues here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 09372df0
...@@ -32,9 +32,10 @@ ...@@ -32,9 +32,10 @@
#include "comedidev.h" #include "comedidev.h"
#include "comedi_fops.h" #include "comedi_fops.h"
#include <linux/proc_fs.h> #include <linux/proc_fs.h>
/* #include <linux/string.h> */ #include <linux/string.h>
int comedi_read_procmem(char *buf, char **start, off_t offset, int len, #ifdef CONFIG_PROC_FS
static int comedi_read(char *buf, char **start, off_t offset, int len,
int *eof, void *data) int *eof, void *data)
{ {
int i; int i;
...@@ -82,18 +83,17 @@ int comedi_read_procmem(char *buf, char **start, off_t offset, int len, ...@@ -82,18 +83,17 @@ int comedi_read_procmem(char *buf, char **start, off_t offset, int len,
return l; return l;
} }
#ifdef CONFIG_PROC_FS
void comedi_proc_init(void) void comedi_proc_init(void)
{ {
struct proc_dir_entry *comedi_proc; struct proc_dir_entry *comedi_proc;
comedi_proc = create_proc_entry("comedi", S_IFREG | S_IRUGO, 0); comedi_proc = create_proc_entry("comedi", S_IFREG | S_IRUGO, NULL);
if (comedi_proc) if (comedi_proc)
comedi_proc->read_proc = comedi_read_procmem; comedi_proc->read_proc = comedi_read;
} }
void comedi_proc_cleanup(void) void comedi_proc_cleanup(void)
{ {
remove_proc_entry("comedi", 0); remove_proc_entry("comedi", NULL);
} }
#endif #endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment