Commit 22dec134 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: seq: oss: Fix data-race for max_midi_devs access

ALSA OSS sequencer refers to a global variable max_midi_devs at
creating a new port, storing it to its own field.  Meanwhile this
variable may be changed by other sequencer events at
snd_seq_oss_midi_check_exit_port() in parallel, which may cause a data
race.

OTOH, this data race itself is almost harmless, as the access to the
MIDI device is done via get_mdev() and it's protected with a refcount,
hence its presence is guaranteed.

Though, it's sill better to address the data-race from the code sanity
POV, and this patch adds the proper spinlock for the protection.
Reported-by: default avatarAbhishek Shah <abhishek.shah@columbia.edu>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAEHB2493pZRXs863w58QWnUTtv3HHfg85aYhLn5HJHCwxqtHQg@mail.gmail.com
Link: https://lore.kernel.org/r/20220823072717.1706-1-tiwai@suse.deSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent a8d302a0
...@@ -270,7 +270,9 @@ snd_seq_oss_midi_clear_all(void) ...@@ -270,7 +270,9 @@ snd_seq_oss_midi_clear_all(void)
void void
snd_seq_oss_midi_setup(struct seq_oss_devinfo *dp) snd_seq_oss_midi_setup(struct seq_oss_devinfo *dp)
{ {
spin_lock_irq(&register_lock);
dp->max_mididev = max_midi_devs; dp->max_mididev = max_midi_devs;
spin_unlock_irq(&register_lock);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment