Commit 22df2459 authored by Dmitry Torokhov's avatar Dmitry Torokhov

Input: iqs62x-keys - use cleanup facility for fwnodes

Use __free(fwnode_handle) cleanup facility to ensure that references
to acquired fwnodes are dropped at appropriate times automatically.
Reviewed-by: default avatarJeff LaBundy <jeff@labundy.com>
Link: https://lore.kernel.org/r/20240825051627.2848495-9-dmitry.torokhov@gmail.comSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 43a365ab
...@@ -45,7 +45,6 @@ struct iqs62x_keys_private { ...@@ -45,7 +45,6 @@ struct iqs62x_keys_private {
static int iqs62x_keys_parse_prop(struct platform_device *pdev, static int iqs62x_keys_parse_prop(struct platform_device *pdev,
struct iqs62x_keys_private *iqs62x_keys) struct iqs62x_keys_private *iqs62x_keys)
{ {
struct fwnode_handle *child;
unsigned int val; unsigned int val;
int ret, i; int ret, i;
...@@ -68,7 +67,8 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, ...@@ -68,7 +67,8 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev,
} }
for (i = 0; i < ARRAY_SIZE(iqs62x_keys->switches); i++) { for (i = 0; i < ARRAY_SIZE(iqs62x_keys->switches); i++) {
child = device_get_named_child_node(&pdev->dev, struct fwnode_handle *child __free(fwnode_handle) =
device_get_named_child_node(&pdev->dev,
iqs62x_switch_names[i]); iqs62x_switch_names[i]);
if (!child) if (!child)
continue; continue;
...@@ -77,7 +77,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, ...@@ -77,7 +77,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev,
if (ret) { if (ret) {
dev_err(&pdev->dev, "Failed to read switch code: %d\n", dev_err(&pdev->dev, "Failed to read switch code: %d\n",
ret); ret);
fwnode_handle_put(child);
return ret; return ret;
} }
iqs62x_keys->switches[i].code = val; iqs62x_keys->switches[i].code = val;
...@@ -91,8 +90,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev, ...@@ -91,8 +90,6 @@ static int iqs62x_keys_parse_prop(struct platform_device *pdev,
iqs62x_keys->switches[i].flag = (i == IQS62X_SW_HALL_N ? iqs62x_keys->switches[i].flag = (i == IQS62X_SW_HALL_N ?
IQS62X_EVENT_HALL_N_T : IQS62X_EVENT_HALL_N_T :
IQS62X_EVENT_HALL_S_T); IQS62X_EVENT_HALL_S_T);
fwnode_handle_put(child);
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment