Commit 26379594 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

phy: intel: phy-intel-lgm-combo: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-8-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 780d771d
...@@ -589,13 +589,12 @@ static int intel_cbphy_probe(struct platform_device *pdev) ...@@ -589,13 +589,12 @@ static int intel_cbphy_probe(struct platform_device *pdev)
return intel_cbphy_create(cbphy); return intel_cbphy_create(cbphy);
} }
static int intel_cbphy_remove(struct platform_device *pdev) static void intel_cbphy_remove(struct platform_device *pdev)
{ {
struct intel_combo_phy *cbphy = platform_get_drvdata(pdev); struct intel_combo_phy *cbphy = platform_get_drvdata(pdev);
intel_cbphy_rst_assert(cbphy); intel_cbphy_rst_assert(cbphy);
clk_disable_unprepare(cbphy->core_clk); clk_disable_unprepare(cbphy->core_clk);
return 0;
} }
static const struct of_device_id of_intel_cbphy_match[] = { static const struct of_device_id of_intel_cbphy_match[] = {
...@@ -606,7 +605,7 @@ static const struct of_device_id of_intel_cbphy_match[] = { ...@@ -606,7 +605,7 @@ static const struct of_device_id of_intel_cbphy_match[] = {
static struct platform_driver intel_cbphy_driver = { static struct platform_driver intel_cbphy_driver = {
.probe = intel_cbphy_probe, .probe = intel_cbphy_probe,
.remove = intel_cbphy_remove, .remove_new = intel_cbphy_remove,
.driver = { .driver = {
.name = "intel-combo-phy", .name = "intel-combo-phy",
.of_match_table = of_intel_cbphy_match, .of_match_table = of_intel_cbphy_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment