Commit 26deacb3 authored by Christoph Hellwig's avatar Christoph Hellwig

[PATCH] devfs: ipmi

parent 20389e3d
...@@ -437,10 +437,7 @@ static struct file_operations ipmi_fops = { ...@@ -437,10 +437,7 @@ static struct file_operations ipmi_fops = {
static int ipmi_major = 0; static int ipmi_major = 0;
MODULE_PARM(ipmi_major, "i"); MODULE_PARM(ipmi_major, "i");
static devfs_handle_t devfs_handle;
#define MAX_DEVICES 10 #define MAX_DEVICES 10
static devfs_handle_t handles[MAX_DEVICES];
static void ipmi_new_smi(int if_num) static void ipmi_new_smi(int if_num)
{ {
...@@ -451,8 +448,7 @@ static void ipmi_new_smi(int if_num) ...@@ -451,8 +448,7 @@ static void ipmi_new_smi(int if_num)
snprintf(name, sizeof(name), "ipmidev/%d", if_num); snprintf(name, sizeof(name), "ipmidev/%d", if_num);
handles[if_num] = devfs_register(NULL, name, DEVFS_FL_NONE, devfs_register(NULL, name, 0, ipmi_major, if_num,
ipmi_major, if_num,
S_IFCHR | S_IRUSR | S_IWUSR, S_IFCHR | S_IRUSR | S_IWUSR,
&ipmi_fops, NULL); &ipmi_fops, NULL);
} }
...@@ -462,7 +458,7 @@ static void ipmi_smi_gone(int if_num) ...@@ -462,7 +458,7 @@ static void ipmi_smi_gone(int if_num)
if (if_num > MAX_DEVICES) if (if_num > MAX_DEVICES)
return; return;
devfs_unregister(handles[if_num]); devfs_remove("ipmidev/%d", if_num);
} }
static struct ipmi_smi_watcher smi_watcher = static struct ipmi_smi_watcher smi_watcher =
...@@ -488,7 +484,7 @@ static __init int init_ipmi_devintf(void) ...@@ -488,7 +484,7 @@ static __init int init_ipmi_devintf(void)
ipmi_major = rv; ipmi_major = rv;
} }
devfs_handle = devfs_mk_dir(DEVICE_NAME); devfs_mk_dir(DEVICE_NAME);
rv = ipmi_smi_watcher_register(&smi_watcher); rv = ipmi_smi_watcher_register(&smi_watcher);
if (rv) { if (rv) {
...@@ -507,7 +503,7 @@ module_init(init_ipmi_devintf); ...@@ -507,7 +503,7 @@ module_init(init_ipmi_devintf);
static __exit void cleanup_ipmi(void) static __exit void cleanup_ipmi(void)
{ {
ipmi_smi_watcher_unregister(&smi_watcher); ipmi_smi_watcher_unregister(&smi_watcher);
devfs_unregister(devfs_handle); devfs_remove(DEVICE_NAME);
unregister_chrdev(ipmi_major, DEVICE_NAME); unregister_chrdev(ipmi_major, DEVICE_NAME);
} }
module_exit(cleanup_ipmi); module_exit(cleanup_ipmi);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment