Commit 286c9408 authored by Christoph Hellwig's avatar Christoph Hellwig

mpt2sas: simplify ->change_queue_depth

Merge two functions, and remove overly verbose debugging output that pokes
into mid-layer internal structures.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
parent db5ed4df
...@@ -1179,15 +1179,14 @@ _scsih_build_scatter_gather(struct MPT2SAS_ADAPTER *ioc, ...@@ -1179,15 +1179,14 @@ _scsih_build_scatter_gather(struct MPT2SAS_ADAPTER *ioc,
} }
/** /**
* _scsih_adjust_queue_depth - setting device queue depth * _scsih_change_queue_depth - setting device queue depth
* @sdev: scsi device struct * @sdev: scsi device struct
* @qdepth: requested queue depth * @qdepth: requested queue depth
* *
* * Returns queue depth.
* Returns nothing
*/ */
static void static int
_scsih_adjust_queue_depth(struct scsi_device *sdev, int qdepth) _scsih_change_queue_depth(struct scsi_device *sdev, int qdepth)
{ {
struct Scsi_Host *shost = sdev->host; struct Scsi_Host *shost = sdev->host;
int max_depth; int max_depth;
...@@ -1217,34 +1216,11 @@ _scsih_adjust_queue_depth(struct scsi_device *sdev, int qdepth) ...@@ -1217,34 +1216,11 @@ _scsih_adjust_queue_depth(struct scsi_device *sdev, int qdepth)
spin_unlock_irqrestore(&ioc->sas_device_lock, flags); spin_unlock_irqrestore(&ioc->sas_device_lock, flags);
not_sata: not_sata:
if (!sdev->tagged_supported) if (!sdev->tagged_supported)
max_depth = 1; max_depth = 1;
if (qdepth > max_depth) if (qdepth > max_depth)
qdepth = max_depth; qdepth = max_depth;
scsi_change_queue_depth(sdev, qdepth); return scsi_change_queue_depth(sdev, qdepth);
}
/**
* _scsih_change_queue_depth - setting device queue depth
* @sdev: scsi device struct
* @qdepth: requested queue depth
*
* Returns queue depth.
*/
static int
_scsih_change_queue_depth(struct scsi_device *sdev, int qdepth)
{
_scsih_adjust_queue_depth(sdev, qdepth);
if (sdev->inquiry_len > 7)
sdev_printk(KERN_INFO, sdev, "qdepth(%d), tagged(%d), "
"simple(%d), scsi_level(%d), cmd_que(%d)\n",
sdev->queue_depth, sdev->tagged_supported, sdev->simple_tags,
sdev->scsi_level,
(sdev->inquiry[7] & 2) >> 1);
return sdev->queue_depth;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment