Commit 28c947d5 authored by William Lee Irwin III's avatar William Lee Irwin III Committed by Linus Torvalds

[PATCH] fix unresolved MTD symbols in scx200_docflash.c

This driver is using some private #ifdef to try to control the use of
partitions and calling functions that get compiled out of the kernel if it's
set (which it is by default).  This results in unresolved module symbols,
which are bad.

This patch synchronizes the conditional compilation of partition management in
the driver with the global config option for MTD partition management and
thereby fixes the unresolved symbol problem.
Signed-off-by: default avatarWilliam Irwin <wli@holomorphy.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 135a8811
...@@ -26,9 +26,6 @@ MODULE_AUTHOR("Christer Weinigel <wingel@hack.org>"); ...@@ -26,9 +26,6 @@ MODULE_AUTHOR("Christer Weinigel <wingel@hack.org>");
MODULE_DESCRIPTION("NatSemi SCx200 DOCCS Flash Driver"); MODULE_DESCRIPTION("NatSemi SCx200 DOCCS Flash Driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
/* Set this to one if you want to partition the flash */
#define PARTITION 1
static int probe = 0; /* Don't autoprobe */ static int probe = 0; /* Don't autoprobe */
static unsigned size = 0x1000000; /* 16 MiB the whole ISA address space */ static unsigned size = 0x1000000; /* 16 MiB the whole ISA address space */
static unsigned width = 8; /* Default to 8 bits wide */ static unsigned width = 8; /* Default to 8 bits wide */
...@@ -50,7 +47,7 @@ static struct resource docmem = { ...@@ -50,7 +47,7 @@ static struct resource docmem = {
static struct mtd_info *mymtd; static struct mtd_info *mymtd;
#if PARTITION #ifdef CONFIG_MTD_PARTITIONS
static struct mtd_partition partition_info[] = { static struct mtd_partition partition_info[] = {
{ {
.name = "DOCCS Boot kernel", .name = "DOCCS Boot kernel",
...@@ -200,7 +197,7 @@ static int __init init_scx200_docflash(void) ...@@ -200,7 +197,7 @@ static int __init init_scx200_docflash(void)
mymtd->owner = THIS_MODULE; mymtd->owner = THIS_MODULE;
#if PARTITION #ifdef CONFIG_MTD_PARTITIONS
partition_info[3].offset = mymtd->size-partition_info[3].size; partition_info[3].offset = mymtd->size-partition_info[3].size;
partition_info[2].size = partition_info[3].offset-partition_info[2].offset; partition_info[2].size = partition_info[3].offset-partition_info[2].offset;
add_mtd_partitions(mymtd, partition_info, NUM_PARTITIONS); add_mtd_partitions(mymtd, partition_info, NUM_PARTITIONS);
...@@ -213,7 +210,7 @@ static int __init init_scx200_docflash(void) ...@@ -213,7 +210,7 @@ static int __init init_scx200_docflash(void)
static void __exit cleanup_scx200_docflash(void) static void __exit cleanup_scx200_docflash(void)
{ {
if (mymtd) { if (mymtd) {
#if PARTITION #ifdef CONFIG_MTD_PARTITIONS
del_mtd_partitions(mymtd); del_mtd_partitions(mymtd);
#else #else
del_mtd_device(mymtd); del_mtd_device(mymtd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment