Commit 299efdc2 authored by Wei Fang's avatar Wei Fang Committed by David S. Miller

net: enetc: check the index of the SFI rather than the handle

We should check whether the current SFI (Stream Filter Instance) table
is full before creating a new SFI entry. However, the previous logic
checks the handle by mistake and might lead to unpredictable behavior.

Fixes: 888ae5a3 ("net: enetc: add tc flower psfp offload driver")
Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c00ce547
...@@ -1247,7 +1247,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv, ...@@ -1247,7 +1247,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
int index; int index;
index = enetc_get_free_index(priv); index = enetc_get_free_index(priv);
if (sfi->handle < 0) { if (index < 0) {
NL_SET_ERR_MSG_MOD(extack, "No Stream Filter resource!"); NL_SET_ERR_MSG_MOD(extack, "No Stream Filter resource!");
err = -ENOSPC; err = -ENOSPC;
goto free_fmi; goto free_fmi;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment