Commit 29d7bbad authored by Anna-Maria Gleixner's avatar Anna-Maria Gleixner Committed by Rafael J. Wysocki

intel_idle: Remove superfluous SMP fuction call

Since commit 1cf4f629 ("cpu/hotplug: Move online calls to
hotplugged cpu") the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are
always run on the hot plugged CPU, and as of commit 3b9d6da6
("cpu/hotplug: Fix rollback during error-out in __cpu_disable()") the
CPU_DOWN_FAILED notifier also runs on the hot plugged CPU. This patch
converts the SMP functional calls into direct calls.

smp_function_call_single() executes the function with interrupts
disabled. This calling convention is not preserved, because
tick_broadcast_enable() and tick_braodcast_disable() handle
interrupts themselves.
Signed-off-by: default avatarAnna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 4e28ec3d
...@@ -971,8 +971,7 @@ static int cpu_hotplug_notify(struct notifier_block *n, ...@@ -971,8 +971,7 @@ static int cpu_hotplug_notify(struct notifier_block *n,
case CPU_ONLINE: case CPU_ONLINE:
if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE) if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE)
smp_call_function_single(hotcpu, __setup_broadcast_timer, __setup_broadcast_timer((void *)true);
(void *)true, 1);
/* /*
* Some systems can hotplug a cpu at runtime after * Some systems can hotplug a cpu at runtime after
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment