Commit 2ac757e4 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net: ethernet: ti: fix return value check in k3_cppi_desc_pool_create_name()

In case of error, the function gen_pool_create() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 93a76530 ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0c2006b2
...@@ -64,8 +64,8 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size, ...@@ -64,8 +64,8 @@ k3_cppi_desc_pool_create_name(struct device *dev, size_t size,
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
pool->gen_pool = gen_pool_create(ilog2(pool->desc_size), -1); pool->gen_pool = gen_pool_create(ilog2(pool->desc_size), -1);
if (IS_ERR(pool->gen_pool)) { if (!pool->gen_pool) {
ret = PTR_ERR(pool->gen_pool); ret = -ENOMEM;
dev_err(pool->dev, "pool create failed %d\n", ret); dev_err(pool->dev, "pool create failed %d\n", ret);
kfree_const(pool_name); kfree_const(pool_name);
goto gen_pool_create_fail; goto gen_pool_create_fail;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment