Commit 2b79b15c authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown

ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index

The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
wrong order, they need to be in pin_index, dir order to match the function
slk_tplg_fill_res_tkn  correctly.

Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")

Fixes: f6fa56e2 ("ASoC: Intel: Skylake: Parse and update module config structure")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-By: default avatarVinod Koul <vinod.koul@intel.com>
Tested-by: default avatarSubhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 948c5e19
...@@ -2382,7 +2382,7 @@ static int skl_tplg_get_token(struct device *dev, ...@@ -2382,7 +2382,7 @@ static int skl_tplg_get_token(struct device *dev,
case SKL_TKN_U32_MAX_MCPS: case SKL_TKN_U32_MAX_MCPS:
case SKL_TKN_U32_OBS: case SKL_TKN_U32_OBS:
case SKL_TKN_U32_IBS: case SKL_TKN_U32_IBS:
ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, dir, pin_index); ret = skl_tplg_fill_res_tkn(dev, tkn_elem, res, pin_index, dir);
if (ret < 0) if (ret < 0)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment