Commit 2c5bfdac authored by Evgeniy Polyakov's avatar Evgeniy Polyakov Committed by Greg Kroah-Hartman

[PATCH] W1: cleanups

Nice cleanup spotted by Adrian Bunk, which was lost due to moving to the
completely new functionality.

Shame-shame-shame on me.
Signed-off-by: default avatarEvgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 339f0723
...@@ -214,11 +214,12 @@ struct device w1_master_device = { ...@@ -214,11 +214,12 @@ struct device w1_master_device = {
.release = &w1_master_release .release = &w1_master_release
}; };
struct device_driver w1_slave_driver = { static struct device_driver w1_slave_driver = {
.name = "w1_slave_driver", .name = "w1_slave_driver",
.bus = &w1_bus_type, .bus = &w1_bus_type,
}; };
#if 0
struct device w1_slave_device = { struct device w1_slave_device = {
.parent = NULL, .parent = NULL,
.bus = &w1_bus_type, .bus = &w1_bus_type,
...@@ -226,6 +227,7 @@ struct device w1_slave_device = { ...@@ -226,6 +227,7 @@ struct device w1_slave_device = {
.driver = &w1_slave_driver, .driver = &w1_slave_driver,
.release = &w1_slave_release .release = &w1_slave_release
}; };
#endif /* 0 */
static ssize_t w1_master_attribute_show_name(struct device *dev, struct device_attribute *attr, char *buf) static ssize_t w1_master_attribute_show_name(struct device *dev, struct device_attribute *attr, char *buf)
{ {
...@@ -383,7 +385,7 @@ int w1_create_master_attributes(struct w1_master *master) ...@@ -383,7 +385,7 @@ int w1_create_master_attributes(struct w1_master *master)
return sysfs_create_group(&master->dev.kobj, &w1_master_defattr_group); return sysfs_create_group(&master->dev.kobj, &w1_master_defattr_group);
} }
void w1_destroy_master_attributes(struct w1_master *master) static void w1_destroy_master_attributes(struct w1_master *master)
{ {
sysfs_remove_group(&master->dev.kobj, &w1_master_defattr_group); sysfs_remove_group(&master->dev.kobj, &w1_master_defattr_group);
} }
......
...@@ -213,6 +213,16 @@ static inline struct w1_master* dev_to_w1_master(struct device *dev) ...@@ -213,6 +213,16 @@ static inline struct w1_master* dev_to_w1_master(struct device *dev)
return container_of(dev, struct w1_master, dev); return container_of(dev, struct w1_master, dev);
} }
extern struct device_driver w1_master_driver;
extern struct bus_type w1_bus_type;
extern struct device w1_master_device;
extern int w1_max_slave_count;
extern int w1_max_slave_ttl;
extern struct list_head w1_masters;
extern struct mutex w1_mlock;
extern int w1_process(void *);
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
#endif /* __W1_H */ #endif /* __W1_H */
...@@ -30,16 +30,6 @@ ...@@ -30,16 +30,6 @@
static u32 w1_ids = 1; static u32 w1_ids = 1;
extern struct device_driver w1_master_driver;
extern struct bus_type w1_bus_type;
extern struct device w1_master_device;
extern int w1_max_slave_count;
extern int w1_max_slave_ttl;
extern struct list_head w1_masters;
extern struct mutex w1_mlock;
extern int w1_process(void *);
static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl, static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl,
struct device_driver *driver, struct device_driver *driver,
struct device *device) struct device *device)
...@@ -96,7 +86,7 @@ static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl, ...@@ -96,7 +86,7 @@ static struct w1_master * w1_alloc_dev(u32 id, int slave_count, int slave_ttl,
return dev; return dev;
} }
void w1_free_dev(struct w1_master *dev) static void w1_free_dev(struct w1_master *dev)
{ {
device_unregister(&dev->dev); device_unregister(&dev->dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment