Commit 2f387f84 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o

jbd2: remove outdated comment

The comment about credit estimates isn't true anymore. We do what the
comment describes now.
Reviewed-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent b34090e5
...@@ -283,16 +283,6 @@ static int start_this_handle(journal_t *journal, handle_t *handle, ...@@ -283,16 +283,6 @@ static int start_this_handle(journal_t *journal, handle_t *handle,
* reduce the free space arbitrarily. Be careful to account for * reduce the free space arbitrarily. Be careful to account for
* those buffers when checkpointing. * those buffers when checkpointing.
*/ */
/*
* @@@ AKPM: This seems rather over-defensive. We're giving commit
* a _lot_ of headroom: 1/4 of the journal plus the size of
* the committing transaction. Really, we only need to give it
* committing_transaction->t_outstanding_credits plus "enough" for
* the log control blocks.
* Also, this test is inconsistent with the matching one in
* jbd2_journal_extend().
*/
if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) { if (__jbd2_log_space_left(journal) < jbd_space_needed(journal)) {
jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle); jbd_debug(2, "Handle %p waiting for checkpoint...\n", handle);
atomic_sub(nblocks, &transaction->t_outstanding_credits); atomic_sub(nblocks, &transaction->t_outstanding_credits);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment