Commit 2f3957c7 authored by Chen Zhongjin's avatar Chen Zhongjin Committed by Luiz Augusto von Dentz

Bluetooth: Fix not cleanup led when bt_init fails

bt_init() calls bt_leds_init() to register led, but if it fails later,
bt_leds_cleanup() is not called to unregister it.

This can cause panic if the argument "bluetooth-power" in text is freed
and then another led_trigger_register() tries to access it:

BUG: unable to handle page fault for address: ffffffffc06d3bc0
RIP: 0010:strcmp+0xc/0x30
  Call Trace:
    <TASK>
    led_trigger_register+0x10d/0x4f0
    led_trigger_register_simple+0x7d/0x100
    bt_init+0x39/0xf7 [bluetooth]
    do_one_initcall+0xd0/0x4e0

Fixes: e64c97b5 ("Bluetooth: Add combined LED trigger for controller power")
Signed-off-by: default avatarChen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 828cea2b
...@@ -737,7 +737,7 @@ static int __init bt_init(void) ...@@ -737,7 +737,7 @@ static int __init bt_init(void)
err = bt_sysfs_init(); err = bt_sysfs_init();
if (err < 0) if (err < 0)
return err; goto cleanup_led;
err = sock_register(&bt_sock_family_ops); err = sock_register(&bt_sock_family_ops);
if (err) if (err)
...@@ -773,6 +773,8 @@ static int __init bt_init(void) ...@@ -773,6 +773,8 @@ static int __init bt_init(void)
sock_unregister(PF_BLUETOOTH); sock_unregister(PF_BLUETOOTH);
cleanup_sysfs: cleanup_sysfs:
bt_sysfs_cleanup(); bt_sysfs_cleanup();
cleanup_led:
bt_leds_cleanup();
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment