Commit 2f97c20e authored by Nicolas Saenz Julienne's avatar Nicolas Saenz Julienne Committed by Linus Walleij

gpio: tps65912: fix wrong container_of arguments

The gpio_chip operations receive a pointer the gpio_chip struct which is
contained in the driver's private struct, yet the container_of call in those
functions point to the mfd struct defined in include/linux/mfd/tps65912.h.

Cc: Stable <stable@vger.kernel.org>
Signed-off-by: default avatarNicolas Saenz Julienne <nicolassaenzj@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9cf75e9e
...@@ -26,9 +26,12 @@ struct tps65912_gpio_data { ...@@ -26,9 +26,12 @@ struct tps65912_gpio_data {
struct gpio_chip gpio_chip; struct gpio_chip gpio_chip;
}; };
#define to_tgd(gc) container_of(gc, struct tps65912_gpio_data, gpio_chip)
static int tps65912_gpio_get(struct gpio_chip *gc, unsigned offset) static int tps65912_gpio_get(struct gpio_chip *gc, unsigned offset)
{ {
struct tps65912 *tps65912 = container_of(gc, struct tps65912, gpio); struct tps65912_gpio_data *tps65912_gpio = to_tgd(gc);
struct tps65912 *tps65912 = tps65912_gpio->tps65912;
int val; int val;
val = tps65912_reg_read(tps65912, TPS65912_GPIO1 + offset); val = tps65912_reg_read(tps65912, TPS65912_GPIO1 + offset);
...@@ -42,7 +45,8 @@ static int tps65912_gpio_get(struct gpio_chip *gc, unsigned offset) ...@@ -42,7 +45,8 @@ static int tps65912_gpio_get(struct gpio_chip *gc, unsigned offset)
static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset, static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset,
int value) int value)
{ {
struct tps65912 *tps65912 = container_of(gc, struct tps65912, gpio); struct tps65912_gpio_data *tps65912_gpio = to_tgd(gc);
struct tps65912 *tps65912 = tps65912_gpio->tps65912;
if (value) if (value)
tps65912_set_bits(tps65912, TPS65912_GPIO1 + offset, tps65912_set_bits(tps65912, TPS65912_GPIO1 + offset,
...@@ -55,7 +59,8 @@ static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset, ...@@ -55,7 +59,8 @@ static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset,
static int tps65912_gpio_output(struct gpio_chip *gc, unsigned offset, static int tps65912_gpio_output(struct gpio_chip *gc, unsigned offset,
int value) int value)
{ {
struct tps65912 *tps65912 = container_of(gc, struct tps65912, gpio); struct tps65912_gpio_data *tps65912_gpio = to_tgd(gc);
struct tps65912 *tps65912 = tps65912_gpio->tps65912;
/* Set the initial value */ /* Set the initial value */
tps65912_gpio_set(gc, offset, value); tps65912_gpio_set(gc, offset, value);
...@@ -66,7 +71,8 @@ static int tps65912_gpio_output(struct gpio_chip *gc, unsigned offset, ...@@ -66,7 +71,8 @@ static int tps65912_gpio_output(struct gpio_chip *gc, unsigned offset,
static int tps65912_gpio_input(struct gpio_chip *gc, unsigned offset) static int tps65912_gpio_input(struct gpio_chip *gc, unsigned offset)
{ {
struct tps65912 *tps65912 = container_of(gc, struct tps65912, gpio); struct tps65912_gpio_data *tps65912_gpio = to_tgd(gc);
struct tps65912 *tps65912 = tps65912_gpio->tps65912;
return tps65912_clear_bits(tps65912, TPS65912_GPIO1 + offset, return tps65912_clear_bits(tps65912, TPS65912_GPIO1 + offset,
GPIO_CFG_MASK); GPIO_CFG_MASK);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment