Commit 3036facb authored by Hannes Frederic Sowa's avatar Hannes Frederic Sowa Committed by David S. Miller

fou: clean up socket with kfree_rcu

fou->udp_offloads is managed by RCU. As it is actually included inside
the fou sockets, we cannot let the memory go out of scope before a grace
period. We either can synchronize_rcu or switch over to kfree_rcu to
manage the sockets. kfree_rcu seems appropriate as it is used by vxlan
and geneve.

Fixes: 23461551 ("fou: Support for foo-over-udp RX path")
Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4d4f3791
...@@ -24,6 +24,7 @@ struct fou { ...@@ -24,6 +24,7 @@ struct fou {
u16 type; u16 type;
struct udp_offload udp_offloads; struct udp_offload udp_offloads;
struct list_head list; struct list_head list;
struct rcu_head rcu;
}; };
#define FOU_F_REMCSUM_NOPARTIAL BIT(0) #define FOU_F_REMCSUM_NOPARTIAL BIT(0)
...@@ -417,7 +418,7 @@ static void fou_release(struct fou *fou) ...@@ -417,7 +418,7 @@ static void fou_release(struct fou *fou)
list_del(&fou->list); list_del(&fou->list);
udp_tunnel_sock_release(sock); udp_tunnel_sock_release(sock);
kfree(fou); kfree_rcu(fou, rcu);
} }
static int fou_encap_init(struct sock *sk, struct fou *fou, struct fou_cfg *cfg) static int fou_encap_init(struct sock *sk, struct fou *fou, struct fou_cfg *cfg)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment