Commit 315318e7 authored by Mark Brown's avatar Mark Brown Committed by Kamal Mostafa

regulator: core: Ensure we lock all regulators

BugLink: http://bugs.launchpad.net/bugs/1578798

commit 49a6bb7a upstream.

The latest workaround for the lockdep interface's not using the second
argument of mutex_lock_nested() changed the loop missed locking the last
regulator due to a thinko with the loop termination condition exiting
one regulator too soon.
Reported-by: default avatarTyler Baker <tyler.baker@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 95fa1421
......@@ -141,7 +141,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
int i;
mutex_lock(&rdev->mutex);
for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
mutex_lock_nested(&rdev->mutex, i);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment