Commit 31e1d260 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Herbert Xu

crypto: ccp - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Gary Hook <gary.hook@amd.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: default avatarGary R Hook <gary.hook@amd.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 97a93b2b
...@@ -286,10 +286,7 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) ...@@ -286,10 +286,7 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
{ {
struct ccp_cmd_queue *cmd_q; struct ccp_cmd_queue *cmd_q;
char name[MAX_NAME_LEN + 1]; char name[MAX_NAME_LEN + 1];
struct dentry *debugfs_info;
struct dentry *debugfs_stats;
struct dentry *debugfs_q_instance; struct dentry *debugfs_q_instance;
struct dentry *debugfs_q_stats;
int i; int i;
if (!debugfs_initialized()) if (!debugfs_initialized())
...@@ -299,24 +296,14 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) ...@@ -299,24 +296,14 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
if (!ccp_debugfs_dir) if (!ccp_debugfs_dir)
ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL); ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
mutex_unlock(&ccp_debugfs_lock); mutex_unlock(&ccp_debugfs_lock);
if (!ccp_debugfs_dir)
return;
ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir); ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir);
if (!ccp->debugfs_instance)
goto err;
debugfs_info = debugfs_create_file("info", 0400, debugfs_create_file("info", 0400, ccp->debugfs_instance, ccp,
ccp->debugfs_instance, ccp,
&ccp_debugfs_info_ops); &ccp_debugfs_info_ops);
if (!debugfs_info)
goto err;
debugfs_stats = debugfs_create_file("stats", 0600, debugfs_create_file("stats", 0600, ccp->debugfs_instance, ccp,
ccp->debugfs_instance, ccp,
&ccp_debugfs_stats_ops); &ccp_debugfs_stats_ops);
if (!debugfs_stats)
goto err;
for (i = 0; i < ccp->cmd_q_count; i++) { for (i = 0; i < ccp->cmd_q_count; i++) {
cmd_q = &ccp->cmd_q[i]; cmd_q = &ccp->cmd_q[i];
...@@ -325,21 +312,12 @@ void ccp5_debugfs_setup(struct ccp_device *ccp) ...@@ -325,21 +312,12 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
debugfs_q_instance = debugfs_q_instance =
debugfs_create_dir(name, ccp->debugfs_instance); debugfs_create_dir(name, ccp->debugfs_instance);
if (!debugfs_q_instance)
goto err;
debugfs_q_stats = debugfs_create_file("stats", 0600, debugfs_q_instance, cmd_q,
debugfs_create_file("stats", 0600,
debugfs_q_instance, cmd_q,
&ccp_debugfs_queue_ops); &ccp_debugfs_queue_ops);
if (!debugfs_q_stats)
goto err;
} }
return; return;
err:
debugfs_remove_recursive(ccp->debugfs_instance);
} }
void ccp5_debugfs_destroy(void) void ccp5_debugfs_destroy(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment