Commit 3596fb0f authored by Linus Torvalds's avatar Linus Torvalds Committed by Stefan Bader

mm: add 'try_get_page()' helper function

CVE-2019-11487

This is the same as the traditional 'get_page()' function, but instead
of unconditionally incrementing the reference count of the page, it only
does so if the count was "safe".  It returns whether the reference count
was incremented (and is marked __must_check, since the caller obviously
has to be aware of it).

Also like 'get_page()', you can't use this function unless you already
had a reference to the page.  The intent is that you can use this
exactly like get_page(), but in situations where you want to limit the
maximum reference count.

The code currently does an unconditional WARN_ON_ONCE() if we ever hit
the reference count issues (either zero or negative), as a notification
that the conditional non-increment actually happened.

NOTE! The count access for the "safety" check is inherently racy, but
that doesn't matter since the buffer we use is basically half the range
of the reference count (ie we look at the sign of the count).
Acked-by: default avatarMatthew Wilcox <willy@infradead.org>
Cc: Jann Horn <jannh@google.com>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
(backported from commit 88b1a17d)
[ Connor Kuehl: instead of using the page_ref wrapper functions from
  a later and invasive commit, just use the functions they wrap
  directly (i.e., atomic_read vs page_ref_count) ]
Signed-off-by: default avatarConnor Kuehl <connor.kuehl@canonical.com>
Acked-by: default avatarTyler Hicks <tyhicks@canonical.com>
Acked-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent e507e5ef
...@@ -988,6 +988,15 @@ static inline int page_mapped(struct page *page) ...@@ -988,6 +988,15 @@ static inline int page_mapped(struct page *page)
return atomic_read(&(page)->_mapcount) >= 0; return atomic_read(&(page)->_mapcount) >= 0;
} }
static inline __must_check bool try_get_page(struct page *page)
{
page = compound_head(page);
if (WARN_ON_ONCE(atomic_read(&page->_count) <= 0))
return false;
atomic_inc(&page->_count);
return true;
}
/* /*
* Return true only if the page has been allocated with * Return true only if the page has been allocated with
* ALLOC_NO_WATERMARKS and the low watermark was not * ALLOC_NO_WATERMARKS and the low watermark was not
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment