Commit 36309d3b authored by David Binder's avatar David Binder Committed by Greg Kroah-Hartman

staging: unisys: visorbus: Use switch statement instead of conditionals

Control flow is now directed using a switch statement, triggered by the
enum crash_obj_type function parameter, instead of a set of conditional
statements.
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDavid Binder <david.binder@unisys.com>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98f9ed9e
...@@ -613,27 +613,33 @@ save_crash_message(struct controlvm_message *msg, enum crash_obj_type typ) ...@@ -613,27 +613,33 @@ save_crash_message(struct controlvm_message *msg, enum crash_obj_type typ)
return err; return err;
} }
if (typ == CRASH_BUS) { switch (typ) {
case CRASH_DEV:
local_crash_msg_offset += sizeof(struct controlvm_message);
err = visorchannel_write(controlvm_channel, err = visorchannel_write(controlvm_channel,
local_crash_msg_offset, local_crash_msg_offset,
msg, msg,
sizeof(struct controlvm_message)); sizeof(struct controlvm_message));
if (err) { if (err) {
POSTCODE_LINUX(SAVE_MSG_BUS_FAILURE_PC, 0, 0, POSTCODE_LINUX(SAVE_MSG_DEV_FAILURE_PC, 0, 0,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
return err; return err;
} }
} else { break;
local_crash_msg_offset += sizeof(struct controlvm_message); case CRASH_BUS:
err = visorchannel_write(controlvm_channel, err = visorchannel_write(controlvm_channel,
local_crash_msg_offset, local_crash_msg_offset,
msg, msg,
sizeof(struct controlvm_message)); sizeof(struct controlvm_message));
if (err) { if (err) {
POSTCODE_LINUX(SAVE_MSG_DEV_FAILURE_PC, 0, 0, POSTCODE_LINUX(SAVE_MSG_BUS_FAILURE_PC, 0, 0,
DIAG_SEVERITY_ERR); DIAG_SEVERITY_ERR);
return err; return err;
} }
break;
default:
pr_info("Invalid crash_obj_type\n");
break;
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment