Commit 368419a2 authored by Michael Riesch's avatar Michael Riesch Committed by Heiko Stuebner

drm/rockchip: vop2: initialize possible_crtcs properly

The variable possible_crtcs is only initialized for primary and
overlay planes. Since the VOP2 driver only supports these plane
types at the moment, the current code is safe. However, in order
to provide a future-proof solution, fix the initialization of
the variable.
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarMichael Riesch <michael.riesch@wolfvision.net>
Reviewed-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230124054706.3921383-2-michael.riesch@wolfvision.net
parent 9bb35d4c
...@@ -2321,10 +2321,11 @@ static int vop2_create_crtc(struct vop2 *vop2) ...@@ -2321,10 +2321,11 @@ static int vop2_create_crtc(struct vop2 *vop2)
/* change the unused primary window to overlay window */ /* change the unused primary window to overlay window */
win->type = DRM_PLANE_TYPE_OVERLAY; win->type = DRM_PLANE_TYPE_OVERLAY;
} }
} } else if (win->type == DRM_PLANE_TYPE_OVERLAY) {
if (win->type == DRM_PLANE_TYPE_OVERLAY)
possible_crtcs = (1 << nvps) - 1; possible_crtcs = (1 << nvps) - 1;
} else {
possible_crtcs = 0;
}
ret = vop2_plane_init(vop2, win, possible_crtcs); ret = vop2_plane_init(vop2, win, possible_crtcs);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment