Commit 38b8cc90 authored by Liviu Dudau's avatar Liviu Dudau Committed by Khalid Elmously

mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()

BugLink: https://bugs.launchpad.net/bugs/1883917

commit 6ade2032 upstream.

find_vmap_area() can return a NULL pointer and we're going to
dereference it without checking it first.  Use the existing
find_vm_area() function which does exactly what we want and checks for
the NULL pointer.

Link: http://lkml.kernel.org/r/20181228171009.22269-1-liviu@dudau.co.uk
Fixes: f3c01d2f ("mm: vmalloc: avoid racy handling of debugobjects in vunmap")
Signed-off-by: default avatarLiviu Dudau <liviu@dudau.co.uk>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Chintan Pandya <cpandya@codeaurora.org>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
parent 72a767ef
......@@ -1464,7 +1464,7 @@ static void __vunmap(const void *addr, int deallocate_pages)
addr))
return;
area = find_vmap_area((unsigned long)addr)->vm;
area = find_vm_area(addr);
if (unlikely(!area)) {
WARN(1, KERN_ERR "Trying to vfree() nonexistent vm area (%p)\n",
addr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment