Commit 38bf8cd8 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller

selftests: fix poll error in udpgro.sh

The test program udpgso_bench_rx always invokes the poll()
syscall with a timeout of 10ms. If a larger timeout is specified
via the command line, udpgso_bench_rx is supposed to do multiple
poll() calls till the timeout is expired or an event is received.

Currently the poll() loop errors out after the first invocation with
no events, and may causes self-tests failure alike:

failed
 GRO with custom segment size            ./udpgso_bench_rx: poll: 0x0 expected 0x1

This change addresses the issue allowing the poll() loop to consume
all the configured timeout.

Fixes: ada641ff ("selftests: fixes for UDP GRO")
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 177745be
...@@ -113,6 +113,9 @@ static void do_poll(int fd, int timeout_ms) ...@@ -113,6 +113,9 @@ static void do_poll(int fd, int timeout_ms)
interrupted = true; interrupted = true;
break; break;
} }
/* no events and more time to wait, do poll again */
continue;
} }
if (pfd.revents != POLLIN) if (pfd.revents != POLLIN)
error(1, errno, "poll: 0x%x expected 0x%x\n", error(1, errno, "poll: 0x%x expected 0x%x\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment